[Minor Breaking API] Make deallocation queues more reliable #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be sure we've released before the queue drains
Adlai-Holler
changed the title
|
Heh, good finds. I’m on my phone at the moment and not totally confident in my review, but I will look into it with more detail when I can (land if you get another though!) |
nguyenhuy
approved these changes
Nov 2, 2017
| @@ -35,7 +35,7 @@ | |||
| #endif | |||
|
|
|||
| /// For deallocation of objects on the main thread across multiple run loops. | |||
| extern void ASPerformMainThreadDeallocation(_Nullable id object); | |||
| extern void ASPerformMainThreadDeallocation(id _Nullable __strong * _Nonnull objectPtr); | |||
There was a problem hiding this comment.
Didn't know this is legit. Learning every day!
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| - [ASNetworkImageNode] New delegate callback to tell the consumer whether the image was loaded from cache or download. [Adlai Holler](https://github.com/Adlai-Holler) | |||
| - [Layout] Fixes a deadlock in layout. [#638](https://github.com/TextureGroup/Texture/pull/638) [Garrett Moon](https://github.com/garrettmoon) | |||
| - Updated to be backwards compatible with Xcode 8. [Adlai Holler](https://github.com/Adlai-Holler) | |||
| - Fixed cases where main-thread-deallocation doesn't work as expected [Adlai Holler](https://github.com/Adlai-Holler) | |||
There was a problem hiding this comment.
Please add a quick note mentioning the API changes.
|
Tested with Pinterest app and confirm that this PR fixes #607. |
maicki
approved these changes
Nov 2, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…roup#651) * Make our async deallocation functions take a double pointer, so we can be sure we've released before the queue drains * Make it a class property * Fix the return type * Use a locker * Improve release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be sure we've released our local reference before the queue releases its reference, we need to pass a double-pointer.
Minor breaking API changes in this diff:
ASPerformBackgroundDeallocation(x) -> ASPerformBackgroundDeallocation(&x)ASDeallocQueue.sharedDeallocationQueue() -> ASDeallocQueue.sharedDeallocationQueueASPerformMainThreadDeallocation(x) -> ASPerformMainThreadDeallocation(&x)