[ASVideoNode] Time observer fix #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Oct 6, 2017
There was a problem hiding this comment.
LGTM!
@nguyenhuy I think at some point would be valuable to go through ASVideoNode and add review the __locked_ / locking strategy. As e.g. I think addPlayerObservers etc should be called with lock held.
|
@maicki Yeap, agreed! |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* [ASVideoNode] Move time observer handling to player observers methods. * Update CHANGELOG.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I was adding a custom seek bar to a video node, and noticed that when changing the played video, I was still getting
didPlayToTimeIntervaldelegate calls for the old video.You can easily see what I mean in this sample project.
The video is reloaded after 2 seconds, and after that, the progress bar goes crazy, switching back and forth between the time info of the two players.
Not releasing the time observer also means that the former video keeps playing in the background, and hence seems to increase CPU consumption (twice the load on my device).
The fix is simple: actually release the time observer when removing the player. Because the observer is linked to the player, I just moved allocation/deallocation of the observer to
addPlayerObservers/removePlayerObservers.Tell me what you think,
Cheers,
Flo