Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCoreAnimationExtras] Update documentation for resizbale images #trivial #492

Merged
merged 3 commits into from
Aug 12, 2017
Merged

[ASCoreAnimationExtras] Update documentation for resizbale images #trivial #492

merged 3 commits into from
Aug 12, 2017

Conversation

Kaspik
Copy link
Contributor

@Kaspik Kaspik commented Aug 3, 2017

Documentation update for Assert.
Follow up on #439

@appleguy - based on #439 (comment), so review is probably for you :)

@nguyenhuy nguyenhuy requested a review from appleguy August 8, 2017 10:21
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement! It might be worth including a link to #439 as a comment, so users can get details in the future.

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Adlai looks, but looks good to me!

@Kaspik
Copy link
Contributor Author

Kaspik commented Aug 11, 2017

@maicki @Adlai-Holler Up and ready! :)

@maicki
Copy link
Contributor

maicki commented Aug 12, 2017

@Kaspik Thanks for working on that!

@maicki maicki merged commit 6b3e2ba into TextureGroup:master Aug 12, 2017
@Kaspik Kaspik deleted the imageResizeModeDocu branch August 16, 2017 01:21
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…ivial (TextureGroup#492)

* Update documentation for resizbale images

* Add documentation to ASDisplayNodeSetResizableContents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants