[ASStackLayoutSpec] Fix interitem spacing not being reset on new lines and add snapshot tests #trivial #491
Conversation
|
🚫 CI failed with log |
nguyenhuy
force-pushed
the
HNLineSpacingTests
branch
from
1e30ca9
to
36506fb
Compare
|
🚫 CI failed with log |
|
Oh wow, thanks for this @nguyenhuy, I didn't know you would get on this so quickly. |
nguyenhuy
force-pushed
the
HNLineSpacingTests
branch
from
2534353
to
62fa873
Compare
|
@flovouin No worries at all! I'm working on improving And I found a bug :) Please see the fix included in this PR here. The problem is that for the last item that can't fit into an existing line, we include interitem spacing into its stack dimension sum and carry that onto a new line. It then causes another item, which otherwise should be the last item of that line, to be pushed to yet another line (see screenshots below). Fix by resetting interitem spacing when we break to a new line. Before: After: |
nguyenhuy
changed the title
|
Oh I see, nice catch! That was a stupid mistake on my side, sorry about that. :/ |
…s, snapshot tests included
nguyenhuy
force-pushed
the
HNLineSpacingTests
branch
from
62fa873
to
281e3b9
Compare
|
🚫 CI failed with log |
|
I didn't catch it during code review, so it's my fault as well :P |
There was a problem hiding this comment.
Really awesome work from @flovouin and @nguyenhuy on all of that!
|
Thanks, @maicki. |
…s and add snapshot tests #trivial (TextureGroup#491) * Add snapshot tests for interitem and interline spacings of stack spec * Improve comment * Make sure item spacings are properly considered and reset on new lines, snapshot tests included
Follow up on #472. Closes #489.