iOS 11 UITableView automatic height estimation fix #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maicki
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
Looks good to me. Maybe we should add some comment above the iOS 11 check to explain why this is necessary. @nguyenhuy what do you think? If not let's just get it in!
|
@maicki That makes sense to me, at first blush it's definitely not obvious why it's there. I added in a note! |
|
Good call, @maicki. Will merge after CI passes. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Add iOS 11 checks. * Negate iOS 11 automatic table height estimatation * Negate iOS 11 automatic estimated table row heights * Add note about iOS 11 estimated height behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in iOS 11
UITableViewautomatically uses estimated heights. (Source)This causes some odd behaviour in Texture, specifically with batch fetching where a lot of jumping can happen when the load occurs.
User djug in the Slack encountered this issue earlier and posted their solution which is the basis for this, and is as simple as re-disabling the new default behaviour so that automatic height estimation does not occur.
In order to let this occur only on iOS 11 (not sure if there's any pre-iOS-11 code running on the assumption of the old default, don't want to cause a regression) I made it only occur on iOS 11 and later. This required an addition to
ASAvailability.h, and like iOS 10 it's unfortunately not explicitly set, so I set it to what iOS 11 beta 4 currently outputs as itskCFCoreFoundationVersionNumber:1438.1.(Interestingly Xcode 9 now allows for Objective-C to use the Swift-esque
@availabilitychecks, which may be worth looking into, but it obviously would break compatibility with previous versions of Xcode.)Overall simple change that helps scrolling on iOS 11 to behave as expected.