[ASCollectionLayout] Add ASCollectionGalleryLayoutSizeProviding #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nguyenhuy
commented
Jul 17, 2017
nguyenhuy
commented
- This allows users to return different sizes based on certain conditions, such as the collection node's bounds or grid constants.
- ASPagerNode will also act as a size provider to ensure all pages have an up-to-date size that is its bounds.
- This allows users to return different sizes based on certain conditions, such as the collection node's bounds or grid constants. - ASPagerNode will also act as a size provider to ensure all pages have an up-to-date size that is its bounds.
garrettmoon
reviewed
Jul 17, 2017
| @@ -36,11 +36,13 @@ - (instancetype)initWithNumberOfColumns:(NSInteger)numberOfColumns headerHeight: | |||
|
|
|||
| - (ASScrollDirection)scrollableDirections | |||
| { | |||
| ASDisplayNodeAssertMainThread(); | |||
There was a problem hiding this comment.
Are these and the below necessary? Seems a little strange to be in 'client' code? Leftover from testing?
There was a problem hiding this comment.
I intentionally added to tell whoever reading this example that these methods are called on main. Some rarely read the documentation :) I can definitely remove it if you think it's excessive.
| @@ -23,7 +40,9 @@ NS_ASSUME_NONNULL_BEGIN | |||
| AS_SUBCLASSING_RESTRICTED | |||
| @interface ASCollectionGalleryLayoutDelegate : NSObject <ASCollectionLayoutDelegate> | |||
|
|
|||
| - (instancetype)initWithScrollableDirections:(ASScrollDirection)scrollableDirections itemSize:(CGSize)itemSize NS_DESIGNATED_INITIALIZER; | |||
There was a problem hiding this comment.
Does this one need to be deprecated?
There was a problem hiding this comment.
No, it was merged last week (#76) and is still in Beta.
garrettmoon
approved these changes
Jul 17, 2017
| @@ -36,11 +36,13 @@ - (instancetype)initWithNumberOfColumns:(NSInteger)numberOfColumns headerHeight: | |||
|
|
|||
| - (ASScrollDirection)scrollableDirections | |||
| { | |||
| ASDisplayNodeAssertMainThread(); | |||
| @@ -23,7 +40,9 @@ NS_ASSUME_NONNULL_BEGIN | |||
| AS_SUBCLASSING_RESTRICTED | |||
| @interface ASCollectionGalleryLayoutDelegate : NSObject <ASCollectionLayoutDelegate> | |||
|
|
|||
| - (instancetype)initWithScrollableDirections:(ASScrollDirection)scrollableDirections itemSize:(CGSize)itemSize NS_DESIGNATED_INITIALIZER; | |||
|
Thanks for the review, @garrettmoon! |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…ureGroup#451) * Add ASCollectionGalleryLayoutSizeProviding - This allows users to return different sizes based on certain conditions, such as the collection node's bounds or grid constants. - ASPagerNode will also act as a size provider to ensure all pages have an up-to-date size that is its bounds. * Update CHANGELOG * ASPagerNode to use gallery layout delegate if told to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.