Upgrade ASLayoutElementContext to an Object #trivial #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
changed the title
|
Note: changed the names to push/pop because the semantics around what operations are allowed weren't totally clear once I moved to an object. Also, of course it would be cleaner to have a separate file and maybe a custom initializer, or even a class-method interface to this stuff, but I just wanted to get the basic approach up. |
nguyenhuy
approved these changes
Jun 9, 2017
Source/Layout/ASLayoutElement.mm
Outdated
|
|
||
| pthread_key_t ASLayoutElementContextKey; | ||
|
|
||
| static void ASLayoutElementDestructor(void *p) { | ||
| if (p != NULL) { | ||
| ASDisplayNodeCFailAssert(@"Thread exited without clearing layout element context!"); |
Source/Layout/ASLayoutElement.mm
Outdated
| // pthread_key_create must be called before the key can be used. This function does that. | ||
| void ASLayoutElementContextEnsureKey() | ||
| { | ||
| static dispatch_once_t onceToken; | ||
| dispatch_once(&onceToken, ^{ | ||
| pthread_key_create(&ASLayoutElementContextKey, free); | ||
| // NOTE: NULL destructorm means that if a thread |
|
Hey Huy, thanks for the review |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Upgrade ASLayoutElementContext to an object * Address feedback from Huy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a ton more flexibility for the future.
I'm on vacation so this was a little bit thrown-together, but I'm excited about it! Please give it a thorough review.
The GitHub diff got a little confused, so some lines that didn't change at all appear to have changed, like: