Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Invalid Layer Bounds in a Nonfatal Assertion #trivial #308

Merged
merged 2 commits into from
May 24, 2017

Conversation

Adlai-Holler
Copy link
Member

  • Modify ASDisplayNodeAssertNonFatal to return YES/NO based on whether assertion passed.
  • Add a nonfatal in _ASDisplayLayer setBounds: to ensure the bounds are valid and ignore-with-nonfatal otherwise.

The motivation for this diff is, in Pinterest we're seeing cases where UIScrollView's own gesture-recognizer is causing nan positions to be set on scroll views' layers. It's extremely unlikely that framework code is responsible for it but we can help catch the problem.

@Adlai-Holler Adlai-Holler requested a review from maicki May 24, 2017 18:19
@Adlai-Holler Adlai-Holler changed the title Catch Invalid Layer Bounds in a Nonfatal Assertion Catch Invalid Layer Bounds in a Nonfatal Assertion #trivial May 24, 2017
@ghost
Copy link

ghost commented May 24, 2017

🚫 CI failed with log

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Adlai-Holler Adlai-Holler merged commit f8c16b7 into master May 24, 2017
@Adlai-Holler Adlai-Holler deleted the AHCatchInvalidCAValues branch May 24, 2017 19:56
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…roup#308)

* Add a non-fatal assertion for setting invalid layer bounds.

* Update message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants