Catch Invalid Layer Bounds in a Nonfatal Assertion #trivial #308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASDisplayNodeAssertNonFatal
to return YES/NO based on whether assertion passed._ASDisplayLayer setBounds:
to ensure the bounds are valid and ignore-with-nonfatal otherwise.The motivation for this diff is, in Pinterest we're seeing cases where UIScrollView's own gesture-recognizer is causing
nan
positions to be set on scroll views' layers. It's extremely unlikely that framework code is responsible for it but we can help catch the problem.