Update contribution guidelines #3

maicki · 2017-04-10T20:01:19Z

No description provided.

CLAassistant · 2017-04-10T20:01:25Z

All committers have signed the CLA.

ghost · 2017-04-10T20:15:46Z

Build failure:

ghost · 2017-04-10T20:35:16Z

Build failure:

ghost · 2017-04-10T20:52:18Z

Build failure:

ghost · 2017-04-10T21:12:58Z

Build failure:

garrettmoon

Good to go once comments are addressed.

garrettmoon · 2017-04-11T22:09:17Z

CONTRIBUTING.md

+# Questions
+
+If you are having difficulties using Texture or have a question about usage, please ask a
+question in our [Slack channel](http://asyncdisplaykit.org/slack.html). **Please do not ask for help by filing Github issues.**


Can you change to http://texturegroup.org/slack.html

garrettmoon · 2017-04-11T22:10:04Z

CONTRIBUTING.md

+
+## Where to Find Known Issues
+
+We use [GitHub Issues](https://github.com/facebook/AsyncDisplayKit/issues) for all bug tracking. We keep a close eye on this and try to make it clear when we have an internal fix in progress. Before filing a new issue, try to make sure your problem doesn't already exist.


Can you change link to https://github.com/texturegroup/texture/issues?

garrettmoon · 2017-04-11T22:10:27Z

CONTRIBUTING.md

+4. If the feature is complex, consider writing an Texture RFC issue. Even if you can’t implement the feature yourself, consider writing an RFC issue. If we do end up accepting the feature, the issue provides the needed documentation for contributors to develop the feature according the specification accepted by the core team. We will tag accepted RFC issues with **Needs Volunteer**.
+5. After discussing the feature you may choose to attempt a Pull Request. If you're at all able, start writing some code. We always have more work to do than time to do it. If you can write some code then that will speed the process along.
+
+In short, if you have an idea that would be nice to have, create an issue on the [TextureGroup](https://github.com/TextureGroup/Texture)[/](https://github.com/TextureGroup/Texture)[Texture](https://github.com/TextureGroup/Texture) repo. If you have a question about requesting a feature, start a discussion in our [Slack channel](http://asyncdisplaykit.org/slack.html).


Update link to http://texturegroup.org/slack.html

garrettmoon · 2017-04-11T22:12:06Z

CONTRIBUTING.md


-## Getting Help
-We use Slack for real-time debugging, community updates, and general talk about ASDK. Signup at http://asdk-slack-auto-invite.herokuapp.com or email AsyncDisplayKit(at)gmail.com to get an invite.
+Complete your CLA here


Here's the CLA link: https://cla-assistant.io/TextureGroup/Texture

garrettmoon · 2017-04-11T22:12:36Z

CONTRIBUTING.md

-## License
-By contributing to AsyncDisplayKit, you agree that your contributions will be
-licensed under its BSD license.
+By contributing to Texture, you agree that your contributions will be licensed under its Apache license.


Apache 2. You can also say, see README.md for more details (I'll be updating it).

garrettmoon · 2017-04-11T22:41:59Z

CONTRIBUTING.md

 //
-//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
+//  Original work Copyright (c) 2014-present, Facebook, Inc.
+//  Modified work Copyright (c) 2017-present, Pinterest, Inc. All rights reserved.
 //  This source code is licensed under the BSD-style license found in the
 //  LICENSE file in the root directory of this source tree. An additional grant
 //  of patent rights can be found in the PATENTS file in the same directory.
 //


Can you change the modified file to have this copyright header:

// Copyright (c) 2014-present, Facebook, Inc. All rights reserved. // This source code is licensed under the BSD-style license found in the // LICENSE file in the root directory of this source tree. An additional grant // of patent rights can be found in the PATENTS file in the same directory. // Modifications to this file made after 4/13/2017 are: Copyright (c) 2017-present, // Pinterest, Inc. Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License.

garrettmoon · 2017-04-11T22:43:44Z

CONTRIBUTING.md

 //
-//  Copyright (c) 2014-present, Facebook, Inc.  All rights reserved.
+//  Copyright (c) 2017-present, Pinterest, Inc.  All rights reserved.


For the new files can you use this:

// Copyright (c) 2017-present, Pinterest, Inc. All rights reserved. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License.

* Update contribution guidelines * Some improvements * Improve code * Update based on feedback

merge master into branch

…ir layout due to another node's Yoga properties changing. Whenever we do a new Yoga layout that is going to be displayed, we call setNeedsLayout on any nodes whose layout has changed. PRESUBMIT=passed BUG=126438367 R=adlai,wiseoldduck CC=goodsons,maicki,maxwang,yt-elements-eng+cl APPROVED=adlai,wiseoldduck REQUIRED_REVIEW=1 DELTA=51 (27 added, 17 deleted, 7 changed) DELTA_BY_EXTENSION=h=3,mm=31 OCL=236253226 FIG_CHANGESET=dfbe7a030652966ffa787b192e70d8b88e365a17 FIG_WORKSPACE=tnorman/3272:ytios P4 change: 238551043

Spm support Approved-by: Shehab Tareque Approved-by: Eugene 'Evgeny' Dymov

maicki requested a review from garrettmoon April 10, 2017 20:01

maicki force-pushed the MSContributionGuidelines branch from ebc370b to d9b4cae Compare April 10, 2017 20:11

garrettmoon force-pushed the master branch from 44af13e to cdad21c Compare April 11, 2017 18:10

maicki force-pushed the MSContributionGuidelines branch from 0d1adcb to bd44082 Compare April 11, 2017 20:20

garrettmoon approved these changes Apr 11, 2017

View reviewed changes

garrettmoon reviewed Apr 11, 2017

View reviewed changes

maicki added 4 commits April 11, 2017 16:06

Update contribution guidelines

6fcc3be

Some improvements

8fa088a

Improve code

87be558

Update based on feedback

f87fef3

maicki force-pushed the MSContributionGuidelines branch from 2f336be to f87fef3 Compare April 11, 2017 23:07

garrettmoon merged commit 3202959 into master Apr 12, 2017

garrettmoon pushed a commit that referenced this pull request Apr 13, 2017

Update contribution guidelines (#3)

8fa643b

* Update contribution guidelines * Some improvements * Improve code * Update based on feedback

garrettmoon pushed a commit that referenced this pull request Apr 14, 2017

Update contribution guidelines (#3)

fa08bd0

* Update contribution guidelines * Some improvements * Improve code * Update based on feedback

garrettmoon pushed a commit that referenced this pull request Apr 14, 2017

Update contribution guidelines (#3)

b74af6a

* Update contribution guidelines * Some improvements * Improve code * Update based on feedback

appleguy mentioned this pull request Apr 23, 2017

[ASDisplayNode] Locking on isSynchronous is avoidable and sometimes deadlocks. #64

Closed

This was referenced May 1, 2017

[ASCollectionView] Use UICollectionViewLayout invalidation events to relayout #105

Open

[Crash] ASDN::Mutex::~Mutex() #136

Closed

maicki deleted the MSContributionGuidelines branch May 3, 2017 17:52

harryworld pushed a commit to harryworld/Texture that referenced this pull request Aug 28, 2017

Merge pull request TextureGroup#3 from Grabble/master

cbf704a

merge master into branch

siucarlos mentioned this pull request Jul 23, 2019

[_ASDisplayLayer setDelegate:] is not called by UIViews #1595

Closed

CoderXL mentioned this pull request Sep 28, 2019

ios13 -[ASTextKitContext initWithAttributedString:lineBreakMode:maximumNumberOfLines:exclusionPaths:constrainedSize:] deadlock appear in rare cases #1690

Open

benniebotha pushed a commit to atlassian-forks/Texture that referenced this pull request Jun 28, 2021

Merged in spm-support-no-ig (pull request TextureGroup#3)

5dd56ac

Spm support Approved-by: Shehab Tareque Approved-by: Eugene 'Evgeny' Dymov

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update contribution guidelines #3

Update contribution guidelines #3

maicki commented Apr 10, 2017

CLAassistant commented Apr 10, 2017 •

edited

Loading

ghost commented Apr 10, 2017

ghost commented Apr 10, 2017

ghost commented Apr 10, 2017

ghost commented Apr 10, 2017

garrettmoon left a comment

garrettmoon Apr 11, 2017

garrettmoon Apr 11, 2017

garrettmoon Apr 11, 2017

garrettmoon Apr 11, 2017

garrettmoon Apr 11, 2017

garrettmoon Apr 11, 2017

garrettmoon Apr 11, 2017


		## Where to Find Known Issues

		We use [GitHub Issues](https://github.com/facebook/AsyncDisplayKit/issues) for all bug tracking. We keep a close eye on this and try to make it clear when we have an internal fix in progress. Before filing a new issue, try to make sure your problem doesn't already exist.

Update contribution guidelines #3

Update contribution guidelines #3

Conversation

maicki commented Apr 10, 2017

CLAassistant commented Apr 10, 2017 • edited Loading

ghost commented Apr 10, 2017

ghost commented Apr 10, 2017

ghost commented Apr 10, 2017

ghost commented Apr 10, 2017

garrettmoon left a comment

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

garrettmoon Apr 11, 2017

Choose a reason for hiding this comment

CLAassistant commented Apr 10, 2017 •

edited

Loading