[Examples] Fix LayoutSpecExamples and LayoutSpecExamples-Swift: image URLs were still pointing to asyncdisplaykit.org #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey were still pointing to asyncdisplaykit.org)
|
🚫 CI failed with log |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
… URLs were still pointing to asyncdisplaykit.org (TextureGroup#275) * Fix Image URLs in LayoutSpecExamples and LayoutSpecExamples-Swift (they were still pointing to asyncdisplaykit.org) * Update documentation of ASMapNode example to accurately reflect implemented layout * Fix headers * More headers fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URLs of images in LayoutSpecExamples and LayoutSpecExamples-Swift were still pointing to asyncdisplaykit.org, so they failed to download. I changed them to point to texturegroup.org.
Also, I corrected documentation of ASMapNode example: The layout shown in documentation was not consistent with the actual implementation of
layoutSpecThatFits:. Now the documentation reflects the real output ofpo [layoutSpec asciiArtString]on debugger.