Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Layout Transition State #trivial #269

Merged
merged 2 commits into from
May 15, 2017

Conversation

Adlai-Holler
Copy link
Member

  • Create a formal asdispalynode_iscancelled_block_t for tracking cancellation of layout transitions.
  • Use atomic variables for transitionID and pendingTransitionID, and take them out from under __instanceLock__.
  • Remove the BOOL transitionInProgress field. Instead, we reset transitionID to Invalid if there is no transition in progress.
  • Use a global autoincrementing int for transition IDs, rather than a separate autoincrement per-node.
    • Could this cause overflow? No, not any time soon. We support up to 2.1 million transitions which should be plenty. We can change the data-type for our transitions in a separate diff if we want to.

@Adlai-Holler Adlai-Holler changed the title Simplify Layout Transition State Simplify Layout Transition State #trivial May 14, 2017
@Adlai-Holler Adlai-Holler force-pushed the AHSimplifyLayoutTransitionTracking branch from 51969b7 to 208161f Compare May 15, 2017 18:46
@ghost
Copy link

ghost commented May 15, 2017

🚫 CI failed with log

@Adlai-Holler Adlai-Holler force-pushed the AHSimplifyLayoutTransitionTracking branch from a8e86b7 to 9389437 Compare May 15, 2017 20:32
@Adlai-Holler Adlai-Holler merged commit 7df1a20 into master May 15, 2017
@Adlai-Holler Adlai-Holler deleted the AHSimplifyLayoutTransitionTracking branch May 15, 2017 23:33
bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
* Port the changes to the latest master

* Remove extra s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants