Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASDisplayNode documentation. #2089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ASDisplayNode documentation. #2089

wants to merge 1 commit into from

Conversation

VAndrJ
Copy link

@VAndrJ VAndrJ commented Aug 25, 2023

Swift does not support @abstract and other directives, leading to quick reference documentation problems in Swift code.

Example:
Screenshot 2023-08-25 at 15 20 58

This PR updates the ASDisplayNode.h documentation comments and adds information for some properties.

Example:
Screenshot 2023-08-25 at 15 20 46

rcancro
rcancro approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@rcancro rcancro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks like a useful update to the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcancro rcancro rcancro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VAndrJ @rcancro