Improve recursive unfair lock #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use relaxed memory since we don't need acquire/release. This'll make it faster. - Add a couple assertions and organize the code better. - In contested case, just lock instead of tryLock-fail-lock. - In recursive case, do not tryLock. Just notice it's recursive and be done. - In uncontested case, just lock instead of tryLock. PRESUBMIT=passed BUG=137413265 R=maicki CC=maxwang,rexhu,wiseoldduck,yt-elements-eng+cl REQUIRED_REVIEW=1 DELTA=50 (14 added, 13 deleted, 23 changed) DELTA_BY_EXTENSION=h=1,mm=36 OCL=278419008 P4 change: 278454084
bolsinga
approved these changes
Dec 10, 2019
bolsinga
pushed a commit
that referenced
this pull request
May 27, 2020
rcancro
pushed a commit
to rcancro/Texture
that referenced
this pull request
May 28, 2020
- Followup to TextureGroup#1742 - At Pinterest this shipped with D516974 in late 02/2020 - As discussed in TextureGroup#858 this is iOS10 or later, so the runtime `gMutex_unfair` check is still necessary for Texture.
piotrdebosz
pushed a commit
to getstoryteller/Texture
that referenced
this pull request
Mar 1, 2021
- Followup to TextureGroup#1742 - At Pinterest this shipped with D516974 in late 02/2020 - As discussed in TextureGroup#858 this is iOS10 or later, so the runtime `gMutex_unfair` check is still necessary for Texture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never experimented with the current (HEAD) version of unfair lock, but this particular version showed benefits across the board and we launched it. Since CATransaction and @synchronized have both moved to unfair lock, there's a clear set of prior art to (try to) use unfair lock. @bolsinga cc #1741