-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new property alwaysHandleTapTruncationAction to ASTextNode2 and ASTextNode. #1520
Conversation
Could you please help to review this pr? Many thanks. @maicki @Adlai-Holler @garrettmoon @appleguy @nguyenhuy @bolsinga |
I can't remember why we decided not to call the delegate method if passthroughNonlinkTouchesEnabled again? I reviewed the original PR but it's not clear why that delegate call is a problem. @maicki What do you think of this diff? |
I found this issue, possibly because of this.Sometimes we don't want to handle these touch actions. @Adlai-Holler @maicki |
@nguyenhuy @Adlai-Holler Please review if possible. |
@maicki ping |
@dirtmelon Thanks for the PR! I'm good with the change. Maybe let's use a different name that is more aligned with the callback method that is called like: |
@maicki I have renamed it, please review it again. |
🚫 CI failed with log |
@nguyenhuy Could you please review it? |
Also, can you please rebase with latest master to fix the CI issue? |
…STextNode. If the alwaysHandleTapTruncationAction is YES, the ASTextNode and ASTextNode2 can handle touches on additional attributed message even passthrough is YES.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks for the contribution!
After this PR,
ASTextNode
andASTextNode2
don't handle touches on additional attributed message ifpassthroughNonlinkTouches
is YES. But sometimes we maybe want to handle these touches action, even ifpassthroughNonlinkTouches
is YES.So I add the new property
alwaysHandleTapTruncationAction
toASTextNode
andASTextNode2
, whenalwaysHandleTapTruncationAction
is YES,ASTextNode
andASTextNode2
always handle touches on additional attributed message.