Refactor signpost code to be safer, more debuggable #1461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
force-pushed
the
AHProfiling
branch
from
d41e1ea
to
2a5dc17
Compare
|
@maicki @nguyenhuy @garrettmoon Review plz? |
maicki
approved these changes
Apr 24, 2019
|
I'm proud of this but I just learned about the new and incredible os_signpost API, which will require the use of macros, and which has such a different API that everything will need to change. Closing this in favor of a diff that I hope comes soon that adds support for that, probably keeping the macros. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're all-C++, we can use
static constexpr boollike this to still verify that something would build if the bool were either way, but still strip code that is unreachable.This fixes warnings about availability when profiling, and it makes the profiling code more readable & syntax highlighted, and it makes sure that you can't break profiling builds inadvertently.
Confirmed that even in debug mode, unreachable code is totally stripped and the entire
ASSignpost*function call is not even present at all in the disassembly unless PROFILE=1.Over time I'd like us to move away from macros when it makes sense.