A11y for scrollnode #1188
Merged
A11y for scrollnode #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06e18a1.
|
becuse ASScollView is not backed by _ASDisplayView but UIScrollView. |
maicki
reviewed
Oct 24, 2018
| @@ -271,4 +271,19 @@ - (NSArray *)accessibilityElements | |||
|
|
|||
| @end | |||
|
|
|||
| @implementation ASDisplayNode (AccessibilityInternal) | |||
|
|
|||
| - (NSArray *)accessibilityElements { | |||
Source/ASScrollNode.mm
Outdated
| @@ -52,6 +52,10 @@ - (void)didMoveToWindow | |||
| } | |||
| } | |||
|
|
|||
| - (NSArray *)accessibilityElements { | |||
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
@wsdwsd0829 The test will not pass if the accessibility inspector is not running (or was at least launched for the simulator we are testing on once). The reason is that calling We had the same issue with #1069 a while back. I would recommend handling it the same way we did in #1069 and disable the lines that are failing currently. |
|
Thanks @wsdwsd0829 for working on this! |
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Add a11y support for ASSCrollNode. * Changelog * Clean up. * fix braces * add test * disable for ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.