Add NSLocking conformance to ASNodeController #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
force-pushed
the
MSAddLockingToASViewController
branch
from
0e0f8af
to
4e9f2bd
Compare
Adlai-Holler
approved these changes
Oct 17, 2018
maicki
force-pushed
the
MSAddLockingToASViewController
branch
from
4e9f2bd
to
2df914f
Compare
|
🚫 CI failed with log |
maicki
force-pushed
the
MSAddLockingToASViewController
branch
from
2df914f
to
66a048e
Compare
|
🚫 CI failed with log |
maicki
force-pushed
the
MSAddLockingToASViewController
branch
from
66a048e
to
dd42d83
Compare
maicki
force-pushed
the
MSAddLockingToASViewController
branch
from
dd42d83
to
83696de
Compare
appleguy
reviewed
Oct 21, 2018
| @@ -35,6 +39,7 @@ - (ASDisplayNode *)node | |||
|
|
|||
| - (void)setupReferencesWithNode:(ASDisplayNode *)node | |||
| { | |||
| ASLockScopeSelf(); | |||
| if (_shouldInvertStrongReference) { | |||
| // The node should own the controller; weak reference from controller to node. | |||
There was a problem hiding this comment.
Is there any risk of deadlock if the node is reaching out to the node controller around the same time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.