Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout ASDeallocQueueV2 #trivial #1143

Merged
merged 5 commits into from
Oct 1, 2018
Merged

Rollout ASDeallocQueueV2 #trivial #1143

merged 5 commits into from
Oct 1, 2018

Conversation

ernestmama
Copy link
Contributor

This improves general performance/energy usage and possibly increase warm starts.

@ghost
Copy link

ghost commented Sep 25, 2018

🚫 CI failed with log

@ernestmama ernestmama changed the title Rollout ASDeallocQueueV2 Rollout ASDeallocQueueV2 #trivial Sep 25, 2018
Source/ASRunLoopQueue.mm Show resolved Hide resolved
examples/CatDealsCollectionView/Sample/AppDelegate.m Outdated Show resolved Hide resolved
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

@@ -53,7 +53,6 @@ @implementation ASConfiguration (UserProvided)
+ (ASConfiguration *)textureConfiguration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not just remove the whole Category here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -53,7 +53,6 @@ @implementation ASConfiguration (UserProvided)
+ (ASConfiguration *)textureConfiguration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nguyenhuy nguyenhuy merged commit 5e05793 into TextureGroup:master Oct 1, 2018
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants