Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored accessibleElements to accessibilityElements #1069

Merged
merged 5 commits into from
Aug 24, 2018
Merged

Refactored accessibleElements to accessibilityElements #1069

merged 5 commits into from
Aug 24, 2018

Commits on Aug 9, 2018

  1. Refactored accessibleElements to accessibilityElements, and remov…

    …ed the re-definition of the property.
    
    With this refactor, the field can now be used as a single access point into the accessibility elements of a view. Also, removing the re-definition of the property in _ASDisplayViewAccessibility.h enables us to make use of the field and its associated helper methods directly from the `UIAccessibilityContainer` API rather than rolling our own implementation.
    jiawernlim committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    a3eecd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    586cc46 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Configuration menu
    Copy the full SHA
    0a5b3a2 View commit details
    Browse the repository at this point in the history
  2. Commented out tests for older a11y accessors & added relevant warnings.

    Also added assertions that the getter and setter for the accessibilityElements
    property are used only on the main thread.
    jiawernlim committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    2018422 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6703c38 View commit details
    Browse the repository at this point in the history