Fix warning for ASLayout method override for the designated initializer of the superclass '-init' not found #trivial #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
requested changes
Jul 17, 2018
Source/Layout/ASLayout.mm
Outdated
| { | ||
| ASDisplayNodeAssert(NO, @"Use the designated initializer"); | ||
| return [self init]; | ||
| } |
There was a problem hiding this comment.
Rather than doing this, let's move the declaration for this out of the "Unavailable" category in the header file, into the primary class interface. That'll get rid of the warning.
There was a problem hiding this comment.
Yeah decided between that and doing this. We do the same I put up in ASLayoutTransitionI will change it in there too. Updated.
Adlai-Holler
approved these changes
Jul 17, 2018
…er of the superclass '-init' not found
Adlai-Holler
force-pushed
the
MSFixASLayoutInitializerWarning
branch
from
9412f02
to
76f1e20
Compare
nguyenhuy
approved these changes
Jul 18, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…er of the superclass '-init' not found #trivial (TextureGroup#1036) * Fix warning for ASLayout method override for the designated initializer of the superclass '-init' not found * Move unavailable init into header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.