Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Decision on ASExperimentalTextNode #1843

Open
bolsinga opened this issue May 27, 2020 · 3 comments
Open

Ship Decision on ASExperimentalTextNode #1843

bolsinga opened this issue May 27, 2020 · 3 comments

Comments

@bolsinga
Copy link
Contributor

bolsinga commented May 27, 2020

ASExperimentalTextNode is in the code. Should it be on or off?

Added with #259

Looks like 6.79 had this on in PINS. D334230 enabled the XP, but it was shut down. PERF-2781 tracks re-enabling.

@bolsinga
Copy link
Contributor Author

@Adlai-Holler Do you know the status of this for other clients? Thanks.

@Adlai-Holler
Copy link
Member

Google is using ASTextNode2 universally, but last I checked Pinterest was not interested in it. If that's still the case, I'd recommend removing the "experimental" gating around it and simply have it be an option which kind of text node you want. Perhaps a class method on ASTextNode like +coreTextTextNode and +textKitTextNode. cc @wiseoldduck

@bolsinga
Copy link
Contributor Author

Thanks @Adlai-Holler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants