[GitHub CI] Revert back to Ruby Danger as Danger JS is not working pr…

…operly (#1650)

* Update ci.yml

Add name to the script run phase

* Revert back Dangerfile and remove danger JS, create separate workflow for push for tests and for PR for tests + danger, run ruby danger as part of the PR check

* remove PR ci

* Revert "remove PR ci"

This reverts commit 839ba3a.

* cahnge token to default one

* PR feedback

* Rename danger.yml name

.github/workflows/ci.yml

@@ -29,4 +29,5 @@ jobs:
     steps:
     - name: Checkout the Git repository
       uses: actions/checkout@v1
-    - run: ./build.sh ${{ matrix.mode }}
+    - name: Run build script
+      run: ./build.sh ${{ matrix.mode }}

.github/workflows/danger.yml

@@ -3,26 +3,19 @@ name: Danger
 on: [pull_request]
 
 jobs:
-  danger:
-    name: Danger JS
-    runs-on: ubuntu-latest
+  buildsh:
+    strategy:
+      matrix:
+        mode: [danger]
+        include:
+          - mode: danger
+            name: Run Danger
+    name: ${{ matrix.name }}
+    runs-on: macOS-10.14
     steps:
     - name: Checkout the Git repository
       uses: actions/checkout@v1
-    # TODO: Figure out why GITHUB_TOKEN isn't enough for Danger JS to create a comment.
-    # Our dangerfile.js escalates any warnings as failures to get more attention.
-    #
-    # Here is the error response from GitHub API:
-    #
-    # Request failed [403]: https://api.github.com/repos/TextureGroup/Texture/issues/1635/comments
-    # Response: {
-    #   "message": "Resource not accessible by integration",
-    #   "documentation_url": "https://developer.github.com/v3/issues/comments/#create-a-comment"
-    # }
-    #
-    # https://github.com/TextureGroup/Texture/pull/1635/checks?check_run_id=200541353
-    - name: Danger
-      uses: danger/danger-js@9.1.8
+    - name: Run build script
+      run: ./build.sh ${{ matrix.mode }}
       env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        DANGER_DISABLE_TRANSPILATION: true 
+        DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Dangerfile

@@ -0,0 +1,83 @@
+require 'open-uri'
+
+source_pattern = /(\.m|\.mm|\.h)$/
+
+modified_source_files = git.modified_files.grep(source_pattern)
+has_modified_source_files = !modified_source_files.empty?
+added_source_files = git.added_files.grep(source_pattern)
+has_added_source_files = !added_source_files.empty?
+
+# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
+warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
+
+# Warn when there is a big PR
+warn("This is a big PR, please consider splitting it up to ease code review.") if git.lines_of_code > 500
+
+# Modifying the changelog will probably get overwritten.
+if git.modified_files.include?("CHANGELOG.md") && !github.pr_title.include?("#changelog")
+  warn("PR modifies CHANGELOG.md, which is a generated file. Add #changelog to the title to suppress this warning.")
+end
+
+def full_license(partial_license, filename)
+    license_header = <<-HEREDOC
+//
+    HEREDOC
+    license_header += "//  " + filename + "\n"
+    license_header += <<-HEREDOC
+//  Texture
+//
+    HEREDOC
+    license_header += partial_license
+    return license_header
+end
+
+def check_file_header(files_to_check, licenses)
+  repo_name = github.pr_json["base"]["repo"]["full_name"]
+  pr_number = github.pr_json["number"]
+  files = github.api.pull_request_files(repo_name, pr_number)
+  files.each do |file|
+    if files_to_check.include?(file["filename"])
+      filename = File.basename(file["filename"])
+
+      data = ""
+      contents = github.api.get file["contents_url"]
+      open(contents["download_url"]) { |io|
+        data += io.read
+      }
+
+      correct_license = false
+      licenses.each do |license|
+        license_header = full_license(license, filename)
+        if data.include? "Pinterest, Inc."
+          correct_license = true
+        end
+      end
+
+      if correct_license == false
+        warn ("Please ensure license is correct for #{filename}: \n```\n" + full_license(licenses[0], filename) + "```")
+      end
+
+    end
+  end
+end
+
+# Ensure new files have proper header
+new_source_license_header = <<-HEREDOC
+//  Copyright (c) Pinterest, Inc.  All rights reserved.
+//  Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
+HEREDOC
+
+if has_added_source_files
+  check_file_header(added_source_files, [new_source_license_header])
+end
+
+# Ensure modified files have proper header
+modified_source_license_header = <<-HEREDOC
+//  Copyright (c) Facebook, Inc. and its affiliates.  All rights reserved.
+//  Changes after 4/13/2017 are: Copyright (c) Pinterest, Inc.  All rights reserved.
+//  Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
+HEREDOC
+
+if has_modified_source_files
+  check_file_header(modified_source_files, [modified_source_license_header, new_source_license_header])
+end

build.sh

@@ -80,6 +80,13 @@ if [ "$MODE" = "tests" -o "$MODE" = "all" ]; then
     success="1"
 fi
 
+if [ "$MODE" = "danger" -o "$MODE" = "all" ]; then
+    bundle install
+    echo "Running Danger..."
+    bundle exec danger --fail-on-errors=true
+    success="1"
+fi
+
 if [ "$MODE" = "tests_listkit" ]; then
     echo "Building & testing AsyncDisplayKit+IGListKit."
     pod install --project-directory=SubspecWorkspaces/ASDKListKit