snaphots

Author: willmcgugan

src/textual/_styles_cache.py

@@ -350,7 +350,9 @@ def post(segments: Iterable[Segment]) -> Iterable[Segment]:
                 ansi_theme = DEFAULT_TERMINAL_THEME
 
             if styles.tint.a:
-                segments = Tint.process_segments(segments, styles.tint, ansi_theme)
+                segments = Tint.process_segments(
+                    segments, styles.tint, ansi_theme, background
+                )
             if opacity != 1.0:
                 segments = _apply_opacity(segments, base_background, opacity)
             return segments

src/textual/constants.py

@@ -167,6 +167,6 @@ def _get_textual_animations() -> AnimationLevel:
 """
 
 DIM_FACTOR: Final[float] = (
-    _get_environ_int("TEXTUAL_DIM_FACTOR", 50, minimum=0, maximum=100) / 100
+    _get_environ_int("TEXTUAL_DIM_FACTOR", 66, minimum=0, maximum=100) / 100
 )
 """Percentage to use as opacity when converting ANSI 'dim' attribute to RGB."""

src/textual/filter.py

@@ -253,8 +253,9 @@ def truecolor_style(self, style: Style, background: RichColor) -> Style:
         # Convert dim style to RGB
         if style.dim and color is not None:
             color = dim_color(background, color)
+            style += NO_DIM
 
-        return Style.from_color(color, bgcolor)
+        return style + Style.from_color(color, bgcolor)
 
     def apply(self, segments: list[Segment], background: Color) -> list[Segment]:
         """Transform a list of segments.

src/textual/renderables/text_opacity.py

@@ -52,14 +52,18 @@ def __init__(self, renderable: RenderableType, opacity: float = 1.0) -> None:
 
     @classmethod
     def process_segments(
-        cls, segments: Iterable[Segment], opacity: float, ansi_theme: TerminalTheme
+        cls,
+        segments: Iterable[Segment],
+        opacity: float,
+        ansi_theme: TerminalTheme,
     ) -> Iterable[Segment]:
         """Apply opacity to segments.
 
         Args:
             segments: Incoming segments.
             opacity: Opacity to apply.
             ansi_theme: Terminal theme.
+            background: Color of background.
 
         Returns:
             Segments with applied opacity.

src/textual/renderables/tint.py

@@ -7,7 +7,7 @@
 from rich.style import Style
 from rich.terminal_theme import TerminalTheme
 
-from textual.color import Color
+from textual.color import TRANSPARENT, Color
 from textual.filter import ANSIToTruecolor
 
 
@@ -30,14 +30,19 @@ def __init__(
 
     @classmethod
     def process_segments(
-        cls, segments: Iterable[Segment], color: Color, ansi_theme: TerminalTheme
+        cls,
+        segments: Iterable[Segment],
+        color: Color,
+        ansi_theme: TerminalTheme,
+        background: Color = TRANSPARENT,
     ) -> Iterable[Segment]:
         """Apply tint to segments.
 
         Args:
             segments: Incoming segments.
             color: Color of tint.
             ansi_theme: The TerminalTheme defining how to map ansi colors to hex.
+            background: Background color.
 
         Returns:
             Segments with applied tint.
@@ -54,7 +59,11 @@ def process_segments(
             if control:
                 yield segment
             else:
-                style = truecolor_style(style) if style is not None else NULL_STYLE
+                style = (
+                    truecolor_style(style, background)
+                    if style is not None
+                    else NULL_STYLE
+                )
                 yield _Segment(
                     text,
                     (