Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] commonmark dependency is unmaintained #2155

Closed
The-Compiler opened this issue Apr 4, 2022 · 4 comments
Closed

[BUG] commonmark dependency is unmaintained #2155

The-Compiler opened this issue Apr 4, 2022 · 4 comments

Comments

@The-Compiler
Copy link
Contributor

The commonmark repository reads:

This repository has been archived by the owner. It is now read-only.

and

No Maintenance Intended

and

Warning: commonmark.py is now deprecated. We recommend using markdown-it-py for a commonmark parser going forward. See readthedocs/commonmark.py#308 for background and discussion.

Which might mean it should be replaced at some point or another - unless the way it's used in rich makes this situation not a problem.

(took the freedom to delete the issue template - I usually don't do that, but here, nothing of it really applies)

@willmcgugan
Copy link
Collaborator

We do have plans to replace it with a more modern parser, which supports tables and more features. commonmark seems a fairly solid bit of code, so I don't anticipate any problems in the short term.

@The-Compiler
Copy link
Contributor Author

Thanks for the quick answer! 👍 FWIW I can second their recommendation of markdown-it-py - I've used it in a project for a bit of markdown parsing (calculating student grades based on a Markdown checklist, also using Rich by the way!), and I've been happy with it.

@willmcgugan
Copy link
Collaborator

Will track it here. #2156

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Did I solve your problem?

Why not buy the devs a coffee to say thanks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants