fix: initialize drives with root directory #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where drives in the mock file system were not properly initialized with their root directory containers, causing issues when trying to enumerate files on newly created drives. The fix ensures that when a drive is created, its corresponding root directory container is also created in the storage system.
- Initializes the main drive with a root directory container during storage construction
- Updates the
GetOrAddDrivemethod to create root directory containers for new drives - Adds a test to verify that drives can be enumerated without errors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Tests/Testably.Abstractions.Testing.Tests/MockFileSystemTests.cs |
Adds test to verify drive enumeration works correctly with root directories |
Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs |
Initializes main drive with root container and ensures new drives get root containers |
Test Results 37 files ± 0 37 suites ±0 21m 5s ⏱️ +17s For more details on these failures, see this check. Results for commit a8653aa. ± Comparison against base commit c6a2782. This pull request removes 36185 and adds 36186 tests. Note that renamed tests count towards both.This pull request removes 1784 skipped tests and adds 1784 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
vbreuss
force-pushed
the
topic/initialize-drives-with-root-directory
branch
from
9a99ea4 to
dbe1807
Compare
|
|
This is addressed in release v4.3.3. |
This was referenced Sep 8, 2025
This was referenced Sep 11, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 19, 2025
Closed
Closed
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where drives in the mock file system were not properly initialized with their root directory containers, causing issues when trying to enumerate files on newly created drives. The fix ensures that when a drive is created, its corresponding root directory container is also created in the storage system.
Key changes:
GetOrAddDrivemethod to create root directory containers for new drives