fix: return correct Parent of DirectoryInfo with trailing directory separator
#846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the DirectoryInfo.Parent property when the directory path contains a trailing directory separator. The issue was that the parent directory calculation incorrectly included the trailing separator, leading to wrong parent resolution.
Key Changes
- Fixed the
GetParent()method inInMemoryLocationto trim trailing directory separators before calculating the parent path - Added a comprehensive test case to verify the correct parent is returned when a directory path has a trailing separator
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Source/Testably.Abstractions.Testing/Storage/InMemoryLocation.cs |
Modified GetParent() method to trim trailing directory separators before parent path calculation |
Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/Tests.cs |
Added test case and cleaned up existing test assertions to verify correct parent behavior with trailing separators |
vbreuss
changed the title
Parent of DirectoryInfo with trailing directo…Parent of DirectoryInfo with trailing directory separator
Test Results 37 files ± 0 37 suites ±0 20m 59s ⏱️ ±0s Results for commit 48f566a. ± Comparison against base commit 78b0421. This pull request removes 35757 and adds 35788 tests. Note that renamed tests count towards both.This pull request removes 1784 skipped tests and adds 1784 skipped tests. Note that renamed tests count towards both. |
|
|
This is addressed in release v4.3.3. |
This was referenced Sep 8, 2025
Closed
Closed
Closed
This was referenced Sep 12, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 19, 2025
Closed
Closed
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
DirectoryInfo.Parentproperty when the directory path contains a trailing directory separator. The issue was that the parent directory calculation incorrectly included the trailing separator, leading to wrong parent resolution.Key Changes
GetParent()method inInMemoryLocationto trim trailing directory separators before calculating the parent path