fix: correctly handle readonly directories during delete

Author: vbreuss

Source/Testably.Abstractions.Testing/Storage/InMemoryContainer.cs

@@ -190,7 +190,7 @@ public IStorageAccessHandle RequestAccess(FileAccess access, FileShare share,
 		    !ignoreMetadataErrors &&
 		    Attributes.HasFlag(FileAttributes.ReadOnly))
 		{
-			throw ExceptionFactory.AccessToPathDenied();
+			throw ExceptionFactory.AccessToPathDenied(_location.FullPath);
 		}
 #if FEATURE_FILESYSTEM_UNIXFILEMODE
 		if (!deleteAccess && !_fileSystem.UnixFileModeStrategy

Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs

@@ -170,6 +170,7 @@ public bool DeleteContainer(
 				location);
 
 		using (container.RequestAccess(FileAccess.Write, FileShare.ReadWrite,
+			ignoreMetadataErrors: false,
 			deleteAccess: true))
 		{
 			if (_containers.TryRemove(location, out IStorageContainer? removed))

Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs

@@ -62,6 +62,25 @@ await That(Act).Throws<DirectoryNotFoundException>()
 			.WithHResult(-2147024893);
 	}
 
+	[Theory]
+	[AutoData]
+	public async Task Delete_ReadonlyDirectory_ShouldThrowIOExceptionOnWindows(string path)
+	{
+		IDirectoryInfo sut = FileSystem.Directory.CreateDirectory(path);
+		sut.Attributes = FileAttributes.ReadOnly;
+		sut.Refresh();
+
+		void Act()
+		{
+			FileSystem.Directory.Delete(path);
+		}
+
+		await That(Act).Throws<IOException>()
+			.OnlyIf(Test.RunsOnWindows)
+			.WithMessage($"Access to the path '{sut.FullName}' is denied.").And
+			.WithHResult(-2146232800);
+	}
+
 	[Theory]
 	[AutoData]
 	public async Task Delete_Recursive_MissingDirectory_ShouldThrowDirectoryNotFoundException(

Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs

@@ -22,6 +22,25 @@ await That(Act).Throws<DirectoryNotFoundException>()
 			.WithHResult(-2147024893);
 	}
 
+	[Theory]
+	[AutoData]
+	public async Task Delete_ReadonlyDirectory_ShouldThrowIOExceptionOnWindows(string path)
+	{
+		IDirectoryInfo sut = FileSystem.Directory.CreateDirectory(path);
+		sut.Attributes = FileAttributes.ReadOnly;
+		sut.Refresh();
+
+		void Act()
+		{
+			sut.Delete();
+		}
+
+		await That(Act).Throws<IOException>()
+			.OnlyIf(Test.RunsOnWindows)
+			.WithMessage($"Access to the path '{sut.FullName}' is denied.").And
+			.WithHResult(-2146232800);
+	}
+
 	[Theory]
 	[AutoData]
 	public async Task Delete_Recursive_WithOpenFile_ShouldThrowIOException_OnWindows(