fix: throw correct exception when creating a FileStream with invalid mode/access combination
#973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
approved these changes
Apr 19, 2023
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Looks great, thanks!
vbreuss
deleted the
topic/vb/throw-correct-exception-in-stream-constructor
branch
vbreuss
referenced
this pull request
in Testably/Testably.Abstractions
Apr 19, 2023
…19.2.16 (#298) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.15` -> `19.2.16` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.16`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.16) ##### What's Changed - fix: throw correct exception when creating a `FileStream` with invalid mode/access combination by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/TestableIO/System.IO.Abstractions/pull/973](https://togithub.com/TestableIO/System.IO.Abstractions/pull/973) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.15...v19.2.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDkuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
This is addressed in release v19.2.16. |
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884.
In addition to the thrown exceptions some implementations and tests had to be adapted:
File.Openwith Append mode should use Write accessFileInfo.AppendTextshould open the stream with Write accessThe corresponding tests had to be adapted!