Skip to content

Move a readonly file results in inconsistent state #870

@vbreuss

Description

@vbreuss

Describe the bug
Moving a readonly file throws (correctly) an UnauthorizedAccessException, but afterwards both the source file and also the target file exist.

To Reproduce
Consider the following unit test (using Xunit and FluentAssertions):

    [Fact]
    public void MoveFile_WithReadOnlyAttribute_ShouldThrowExceptionAndNotMoveFile()
    {
      var sut = new MockFileSystem();
      sut.File.WriteAllText("foo.txt", "xyz");
      sut.File.SetAttributes("foo.txt", FileAttributes.ReadOnly);
      
      var exception = Record.Exception(() =>
      {
        sut.File.Move("foo.txt", "bar.txt");
      });

      exception.Should().BeAssignableTo<UnauthorizedAccessException>();
      sut.File.Exists("foo.txt").Should().BeTrue();
      sut.File.Exists("bar.txt").Should().BeFalse();
    }

This test fails at the last line, as the file exists now twice, resulting in an inconsistent state of the MockFileSystem

Expected behavior
The unit test should be successful.

Additional context
This issue might have similar root cause as #849 ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: testinghelpersIssues that address the testing helpersstate: in workIssues that are currently worked onstate: releasedIssues that are releasedtype: bugIssues that describe misbehaving functionality

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions