Skip to content

Added direct support for MVC5, pulled out MVC3 and MVC4 projects #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2014

Conversation

robdmoore
Copy link
Member

No description provided.

@robdmoore
Copy link
Member Author

@byteblast this is good to go if you are happy. I modified the CI environment to run all the tests.

After this gets merged we have:

  • TestStack.FluentMVCTesting
  • TestStack.FluentMVCTesting.Mvc4
  • TestStack.FluentMVCTesting.Mvc3

And the dlls in all three get tested by the tests every build.

When deving you can ignore the OldMvc projects since they automatically include everything in the main project. The only implication of how I've done it is if we add a new file or delete a file then you need to unload and reload the projects since they load which files are included when the project is opened.

@AlexArchive
Copy link
Contributor

I made an empty MVC 4 project and then referenced the respective FMT assembly and got this error.

I am not at all sure, but would would it perhaps make sense to reduce the target framework version accordingly?

It may also be a good time to update the readme to reflect the new package arrangement?

Otherwise it looks great bud 🍻

@robdmoore
Copy link
Member Author

Oops. I'll need to fix that - thanks for testing it. Will get back to you when it's sorted.

On 21 Sep 2014, at 1:26 pm, ByteBlast notifications@github.com wrote:

I made an empty MVC 4 project and then referenced the respective FMT assembly and got this error.

I am not at all sure, but would would it perhaps make sense to reduce the target framework version accordingly?

It may also be a good time to update the readme to reflect the new package arrangement?

Otherwise it looks great bud


Reply to this email directly or view it on GitHub.

@robdmoore
Copy link
Member Author

Give it a go now :)

@robdmoore
Copy link
Member Author

also, FYI you can log into the CI server to get the built nuget packages. For this pull request it's at: http://ci.robdmoore.id.au:8010/viewType.html?buildTypeId=TestStackFluentMVCTesting_CI&branch_TestStackFluentMVCTesting=35&tab=buildTypeStatusDiv. Just clikc login as guest and you can see the builds and download the artifacts.

@AlexArchive
Copy link
Contributor

Awesome.

AlexArchive added a commit that referenced this pull request Sep 21, 2014
Added direct support for MVC5, pulled out MVC3 and MVC4 projects
@AlexArchive AlexArchive merged commit a3758b1 into master Sep 21, 2014
@AlexArchive AlexArchive mentioned this pull request Sep 21, 2014
@robdmoore robdmoore deleted the mvc5-support branch September 21, 2014 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants