Recognize .NET Framework versions 4.5 and higher #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immeraufdemhund
suggested changes
Dec 9, 2019
Co-Authored-By: Robert Snyder <immeraufdemhund@hotmail.com>
immeraufdemhund
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447
This PR introduces an heuristic to recognize whether an arbitrary version is in the proper form to represent a framework. The version must be of one of two forms:
Using the registry, it determines what 4.x versions of the .NET Framework are available. They are listed and returned by the
IAvalableRuntimesinterface. The GUI is able to display them as available.This PR does nothing to ensure that the proper flavor of .NET Framework 4.x is actually made available. In particular, this is not tested anywhere. That's a subject for another issue, however.