Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for incremental predicates in delete+insert strategy #86

Merged
merged 4 commits into from
Jun 27, 2023
Merged

added support for incremental predicates in delete+insert strategy #86

merged 4 commits into from
Jun 27, 2023

Conversation

VarunSharma15
Copy link
Contributor

@VarunSharma15 VarunSharma15 commented Jun 23, 2023 •
edited
Loading

Description

Added support for incremental_predicates in delete+insert strategy and added testcases for the same.

image

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md with information about my change

rohitagr06
rohitagr06 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@rohitagr06 rohitagr06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sc250072
sc250072 requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sc250072 sc250072 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to address a comment other wise looks good

.github/workflows/ci-integration-tests.yml Show resolved Hide resolved
@VarunSharma15 VarunSharma15 merged commit e4d7e18 into main Jun 27, 2023
@VarunSharma15 VarunSharma15 deleted the vs255034_IDE-24006_1.4 branch July 3, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitagr06 rohitagr06 rohitagr06 approved these changes

@sc250072 sc250072 sc250072 approved these changes

@tallamohan tallamohan Awaiting requested review from tallamohan

@adamtwo adamtwo Awaiting requested review from adamtwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VarunSharma15 @rohitagr06 @sc250072