Skip to content

Commit 1d02616

Browse files
author
Shubhendu
committed
Incoprated review comments and added more expected behavior details
tendrl-bug-id: #252 Signed-off-by: Shubhendu <shtripat@redhat.com>
1 parent da8da4b commit 1d02616

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

specs/unmanage_cluster.adoc

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,18 +184,28 @@ None
184184
* Check if the flow gets completed successfully and verify if the grafana
185185
dashboard reflects and cluster details available now for the selected cluster
186186

187-
* Verify that not grafana alert dashboards available now for the un-managed
187+
* Verify that no grafana alert dashboards available now for the un-managed
188188
cluster
189189

190190
* Verify that the clusters list report the cluster as un-managed and import
191191
option is enabled now
192192

193193
* Try to import the cluster back and it should be successful. All grafana
194-
dashboards, grafana alert dashboards and UI reflect the cluster details back
194+
dashboards, grafana alert dashboards and UI reflect the cluster details back
195195

196196
* Invoke the REST end point `clusters/{int-id}/unmanage` and the cluster should
197197
be un-managed successfully
198198

199+
* On un-manage cluster completion, the alert dashboards in grafana would vanish
200+
for the entities of the cluster like volume, bricks etc. Verify to make sure the
201+
same happens as expected
202+
203+
* Once cluster is un-managed the details of the cluster would vanish from
204+
dashboards in grafana. Verify the same happens as expected
205+
206+
* Verify that the final alert post un-manage flow, tells about removal of
207+
details from grafana dashboards and grafana alert dashboards
208+
199209

200210
== Documentation impact:
201211

@@ -204,6 +214,9 @@ gets disabled / removed in case a cluster is un-managed
204214

205215
* New API end point should be documented with sample input / output structures
206216

217+
* The expected behavior post un-manage call in grafana dashboards should be
218+
clearly mentioned in documents
219+
207220
== References:
208221

209222
* https://redhat.invisionapp.com/share/8QCOEVEY9

0 commit comments

Comments
 (0)