vulkan int8 kernels#6751
Conversation
Implement Vulkan int8 paths for convolution, convolutiondepthwise, innerproduct, and gemm with scalar fallback and integer dot product shader branches. Add goal.md and enable existing int8 unit tests for Vulkan coverage.
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6751 +/- ##
==========================================
- Coverage 95.78% 94.78% -1.00%
==========================================
Files 946 946
Lines 410528 412347 +1819
==========================================
- Hits 393237 390861 -2376
- Misses 17291 21486 +4195 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46154093ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd9a06adcb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee43f88d03
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| VkMat B = B0; | ||
|
|
||
| // Runtime int8 blobs do not carry scale metadata, so reject before recording int8 pipelines. | ||
| if (!constantA && A.elembits() == 8) |
There was a problem hiding this comment.
Fall back before rejecting dynamic int8 Gemm inputs
When an int8 Gemm has a non-constant A input that is already an 8-bit VkMat (for example fed by a previous requantized int8 layer), this new Vulkan path is selected because the old support_vulkan = false guard was removed, but the first thing it does is return -1. There is no CPU fallback at this point in execution, so extraction fails for a graph shape that the loader now advertises as Vulkan-capable; either keep this case off Vulkan during loading or handle the supplied int8 scale path here.
Useful? React with 👍 / 👎.
No description provided.