Skip to content

isTestMode should be a string in v1 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

isTestMode should be a string in v1 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/main/java/com/telemetrydeck/sdk/Signal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ data class Signal(
/**
* If "true", mark the signal as a testing signal and only show it in a dedicated test mode UI
*/
var isTestMode: Boolean = false
var isTestMode: String = "false"
) {
constructor(appID: UUID, signalType: String, clientUser: String, payload: SignalPayload) : this(appID=appID, type=signalType, clientUser = clientUser, payload = payload.asMultiValueDimension)
}
2 changes: 1 addition & 1 deletion lib/src/main/java/com/telemetrydeck/sdk/TelemetryManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class TelemetryManager(
type = signalType,
clientUser = hashedUser,
payload = payload.asMultiValueDimension,
isTestMode = configuration.testMode
isTestMode = configuration.testMode.toString().lowercase()
)
signal.sessionID = this.configuration.sessionID.toString()
logger?.debug("Created a signal ${signal.type}, session ${signal.sessionID}, test ${signal.isTestMode}")
Expand Down
6 changes: 3 additions & 3 deletions lib/src/test/java/com/telemetrydeck/sdk/TelemetryManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class TelemetryManagerTest {
Assert.assertEquals(config.sessionID, UUID.fromString(queuedSignal.sessionID))
Assert.assertEquals("type", queuedSignal.type)
Assert.assertEquals("6721870580401922549fe8fdb09a064dba5b8792fa018d3bd9ffa90fe37a0149", queuedSignal.clientUser)
Assert.assertEquals(false, queuedSignal.isTestMode)
Assert.assertEquals("false", queuedSignal.isTestMode)
}

@Test
Expand Down Expand Up @@ -190,7 +190,7 @@ class TelemetryManagerTest {
.build(null)
sut.queue("type")

Assert.assertEquals(true, sut.cache?.empty()?.get(0)?.isTestMode)
Assert.assertEquals("true", sut.cache?.empty()?.get(0)?.isTestMode)
}

@Test
Expand All @@ -202,7 +202,7 @@ class TelemetryManagerTest {
.build(null)
sut.queue("type")

Assert.assertEquals(false, sut.cache?.empty()?.get(0)?.isTestMode)
Assert.assertEquals("false", sut.cache?.empty()?.get(0)?.isTestMode)
}

@Test
Expand Down