Skip to content

Commit f2439d7

Browse files
committed
fix: isTestMode should be a string in v1
1 parent 1beae82 commit f2439d7

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

lib/src/main/java/com/telemetrydeck/sdk/Signal.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ data class Signal(
4343
/**
4444
* If "true", mark the signal as a testing signal and only show it in a dedicated test mode UI
4545
*/
46-
var isTestMode: Boolean = false
46+
var isTestMode: String = "false"
4747
) {
4848
constructor(appID: UUID, signalType: String, clientUser: String, payload: SignalPayload) : this(appID=appID, type=signalType, clientUser = clientUser, payload = payload.asMultiValueDimension)
4949
}

lib/src/main/java/com/telemetrydeck/sdk/TelemetryManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class TelemetryManager(
112112
type = signalType,
113113
clientUser = hashedUser,
114114
payload = payload.asMultiValueDimension,
115-
isTestMode = configuration.testMode
115+
isTestMode = configuration.testMode.toString().lowercase()
116116
)
117117
signal.sessionID = this.configuration.sessionID.toString()
118118
logger?.debug("Created a signal ${signal.type}, session ${signal.sessionID}, test ${signal.isTestMode}")

lib/src/test/java/com/telemetrydeck/sdk/TelemetryManagerTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class TelemetryManagerTest {
2828
Assert.assertEquals(config.sessionID, UUID.fromString(queuedSignal.sessionID))
2929
Assert.assertEquals("type", queuedSignal.type)
3030
Assert.assertEquals("6721870580401922549fe8fdb09a064dba5b8792fa018d3bd9ffa90fe37a0149", queuedSignal.clientUser)
31-
Assert.assertEquals(false, queuedSignal.isTestMode)
31+
Assert.assertEquals("false", queuedSignal.isTestMode)
3232
}
3333

3434
@Test
@@ -190,7 +190,7 @@ class TelemetryManagerTest {
190190
.build(null)
191191
sut.queue("type")
192192

193-
Assert.assertEquals(true, sut.cache?.empty()?.get(0)?.isTestMode)
193+
Assert.assertEquals("true", sut.cache?.empty()?.get(0)?.isTestMode)
194194
}
195195

196196
@Test
@@ -202,7 +202,7 @@ class TelemetryManagerTest {
202202
.build(null)
203203
sut.queue("type")
204204

205-
Assert.assertEquals(false, sut.cache?.empty()?.get(0)?.isTestMode)
205+
Assert.assertEquals("false", sut.cache?.empty()?.get(0)?.isTestMode)
206206
}
207207

208208
@Test

0 commit comments

Comments
 (0)