feat(#82): allow floatValue and customUserID to be specified when ending duration signal

Author: kkostov

lib/src/androidTest/java/com/telemetrydeck/sdk/TelemetryDeckTest.kt

@@ -315,6 +315,30 @@ class TelemetryDeckTest {
         }
     }
 
+    @UiThreadTest
+    @Test
+    fun allows_for_duration_tracking_with_floatvalue_customer_id() {
+        val signalCache = startTelemetryDeck(
+            prepareBuilder()
+        )
+
+        // act
+        TelemetryDeck.startDurationSignal("type")
+        TelemetryDeck.stopAndSendDurationSignal("type", floatValue = 10.0, customUserID = "user")
+
+
+        verify {
+            signalCache.add(withArg {
+                assertEquals("type", it.type)
+                val duration =
+                    it.payload.find { it.startsWith("TelemetryDeck.Signal.durationInSeconds:") }
+                assertNotNull(duration)
+                assertEquals(10.0, it.floatValue)
+                assertEquals("04f8996da763b7a969b1028ee3007569eaf3a635486ddab211d512c85b9df8fb", it.clientUser)
+            })
+        }
+    }
+
 
     private fun prepareBuilder(): TelemetryDeck.Builder {
         val httpClient = mockk<TelemetryApiClient>()

lib/src/main/java/com/telemetrydeck/sdk/TelemetryDeck.kt

@@ -164,15 +164,20 @@ class TelemetryDeck(
         trackingProvider.startTracking(signalName, parameters)
     }
 
-    override fun stopAndSendDurationSignal(signalName: String, parameters: Map<String, String>) {
+    override fun stopAndSendDurationSignal(signalName: String, parameters: Map<String, String>, floatValue: Double?, customUserID: String?) {
         val trackingProvider = this.providers.find { it is DurationSignalTrackerProvider } as? DurationSignalTrackerProvider
         if (trackingProvider == null) {
             this.logger?.error("stopAndSendDurationSignal requires the DurationSignalTrackerProvider to be registered")
             return
         }
         val params = trackingProvider.stopTracking(signalName, parameters)
         if (params != null) {
-            processSignal(signalName, params = params)
+            processSignal(
+                signalName,
+                params = params,
+                floatValue = floatValue,
+                customUserID = customUserID
+            )
         }
     }
 
@@ -428,9 +433,11 @@ class TelemetryDeck(
 
         override fun stopAndSendDurationSignal(
             signalName: String,
-            parameters: Map<String, String>
+            parameters: Map<String, String>,
+            floatValue: Double?,
+            customUserID: String?
         ) {
-            getInstance()?.stopAndSendDurationSignal(signalName, parameters)
+            getInstance()?.stopAndSendDurationSignal(signalName, parameters, floatValue, customUserID)
         }
 
         override val signalCache: SignalCache?

lib/src/main/java/com/telemetrydeck/sdk/TelemetryDeckClient.kt

@@ -138,9 +138,11 @@ interface TelemetryDeckClient {
      *
      * @param signalName The name of the signal that was previously started with [startDurationSignal]
      * @param parameters Additional parameters to include with the signal. These will be merged with the parameters provided at the start.
+     * @param floatValue An optional floating-point number that can be used to provide numerical data about the signal.
+     * @param customUserID An optional string specifying a custom user identifier. If provided, it will override the default user identifier from the configuration.
      *
      */
-    fun stopAndSendDurationSignal(signalName: String, parameters: Map<String, String> = emptyMap())
+    fun stopAndSendDurationSignal(signalName: String, parameters: Map<String, String> = emptyMap(), floatValue: Double? = null, customUserID: String? = null)
 
     val configuration: TelemetryManagerConfiguration?
 }