Skip to content

Commit 493af0d

Browse files
committed
feat: apply changes for new providers
1 parent a5b4966 commit 493af0d

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

.idea/misc.xml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/main/java/com/telemetrydeck/sdk/providers/DefaultParameterProvider.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.telemetrydeck.sdk.providers
22

3-
import android.app.Application
3+
import android.content.Context
44
import com.telemetrydeck.sdk.TelemetryDeckProvider
55
import com.telemetrydeck.sdk.TelemetryDeckSignalProcessor
66

@@ -14,7 +14,7 @@ import com.telemetrydeck.sdk.TelemetryDeckSignalProcessor
1414
* that will be added to each telemetry signal.
1515
*/
1616
class DefaultParameterProvider(val defaultParameters: Map<String, String>): TelemetryDeckProvider {
17-
override fun register(ctx: Application?, client: TelemetryDeckSignalProcessor) {
17+
override fun register(ctx: Context?, client: TelemetryDeckSignalProcessor) {
1818
// nothing to do
1919
}
2020

lib/src/main/java/com/telemetrydeck/sdk/providers/DefaultPrefixProvider.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.telemetrydeck.sdk.providers
22

3-
import android.app.Application
3+
import android.content.Context
44
import com.telemetrydeck.sdk.SignalTransform
55
import com.telemetrydeck.sdk.TelemetryDeckProvider
66
import com.telemetrydeck.sdk.TelemetryDeckSignalProcessor
@@ -18,7 +18,7 @@ import com.telemetrydeck.sdk.TelemetryDeckSignalProcessor
1818
*/
1919
class DefaultPrefixProvider(val defaultSignalPrefix: String?, val defaultParameterPrefix: String?) :
2020
TelemetryDeckProvider {
21-
override fun register(ctx: Application?, client: TelemetryDeckSignalProcessor) {
21+
override fun register(ctx: Context?, client: TelemetryDeckSignalProcessor) {
2222
// nothing to do
2323
}
2424

lib/src/main/java/com/telemetrydeck/sdk/providers/DurationSignalTrackerProvider.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.telemetrydeck.sdk.providers
22

3-
import android.app.Application
43
import android.content.Context
54
import androidx.lifecycle.DefaultLifecycleObserver
65
import androidx.lifecycle.LifecycleOwner
@@ -23,9 +22,9 @@ class DurationSignalTrackerProvider : TelemetryDeckProvider, DefaultLifecycleObs
2322
private val fileName = "telemetrydeckduration"
2423
private val fileEncoding = Charsets.UTF_8
2524

26-
override fun register(ctx: Application?, client: TelemetryDeckSignalProcessor) {
25+
override fun register(ctx: Context?, client: TelemetryDeckSignalProcessor) {
2726
this.manager = WeakReference(client)
28-
this.appContext = WeakReference(ctx?.applicationContext)
27+
this.appContext = WeakReference(ctx)
2928
this.state = restoreStateFromDisk() ?: TrackerState(emptyMap())
3029
ProcessLifecycleOwner.get().lifecycle.addObserver(this)
3130
}

lib/src/test/java/com/telemetrydeck/sdk/TelemetryDeckTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ class TelemetryDeckTests {
245245
.build(null)
246246
sut.signal("type")
247247

248-
Assert.assertEquals(4 + 1, sut.providers.count()) // added providers + default ones we always apeend
248+
Assert.assertEquals(5 + 1, sut.providers.count()) // default ones + the one added in the test
249249
Assert.assertTrue(sut.providers.last() is TestTelemetryDeckProvider)
250250
}
251251

0 commit comments

Comments
 (0)