Skip to content

Commit 45f3aa0

Browse files
authored
Merge pull request #66 from TelemetryDeck/fix/#61-improve-compatibility
Remove dependency on Compose plugin, remove ui tooling from debug builds
2 parents 23d5ae8 + 71f346d commit 45f3aa0

File tree

3 files changed

+12
-17
lines changed

3 files changed

+12
-17
lines changed

build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ plugins {
22
alias(libs.plugins.androidLibrary) apply false
33
alias(libs.plugins.kotlin.android) apply false
44
alias(libs.plugins.kotlin.serialization) apply false
5-
alias(libs.plugins.kotlin.compose) apply false
65
alias(libs.plugins.vanniktech.publish) apply false
76
}

gradle/libs.versions.toml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
[versions]
2-
agp = "8.7.3"
2+
agp = "8.8.0"
33
kotlin = "2.0.20"
4-
coreKtx = "1.13.1"
4+
coreKtx = "1.15.0"
55
junit = "4.13.2"
66
junitVersion = "1.2.1"
77
espressoCore = "3.6.1"
88
lifecycleRuntimeKtx = "2.8.7"
9-
activityCompose = "1.9.3"
10-
composeBom = "2024.10.00"
9+
activityCompose = "1.10.0"
10+
composeBom = "2024.04.01"
1111
ktor = "3.0.2"
1212
kotlinx = "1.7.3"
13-
coroutines = "1.9.0"
13+
coroutines = "1.10.1"
1414
vanniktech-publish = "0.30.0"
1515
appcompat = "1.7.0"
1616
mockk = "1.13.13"
@@ -48,5 +48,4 @@ mockk-android = {group = "io.mockk", name = "mockk-android", version.ref = "mock
4848
androidLibrary = { id = "com.android.library", version.ref = "agp" }
4949
kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" }
5050
kotlin-serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
51-
vanniktech-publish = { id = "com.vanniktech.maven.publish", version.ref = "vanniktech-publish" }
52-
kotlin-compose = { id = "org.jetbrains.kotlin.plugin.compose", version.ref = "kotlin" }
51+
vanniktech-publish = { id = "com.vanniktech.maven.publish", version.ref = "vanniktech-publish" }

lib/build.gradle.kts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ plugins {
55
alias(libs.plugins.androidLibrary)
66
alias(libs.plugins.kotlin.android)
77
alias(libs.plugins.kotlin.serialization)
8-
alias(libs.plugins.kotlin.compose)
98
alias(libs.plugins.vanniktech.publish)
109
}
1110

@@ -44,7 +43,7 @@ android {
4443
jvmTarget = "11"
4544
}
4645
buildFeatures {
47-
compose = true
46+
compose = false
4847
buildConfig = true
4948
}
5049

@@ -68,10 +67,6 @@ dependencies {
6867
implementation(libs.androidx.core.ktx)
6968
implementation(libs.androidx.lifecycle.runtime.ktx)
7069
implementation(libs.androidx.lifecycle.process)
71-
// explicit dependency on compose seems to be required to use the compose compiler
72-
// this is not used by the library atm
73-
implementation(libs.androidx.activity.compose)
74-
implementation(platform(libs.androidx.compose.bom))
7570
implementation(libs.androidx.appcompat)
7671
implementation(libs.ktor.client.core)
7772
implementation(libs.kotlinx.coroutines.core)
@@ -86,13 +81,15 @@ dependencies {
8681

8782
testImplementation(libs.junit)
8883
testImplementation(libs.androidx.arch.core)
89-
84+
// As of Kotlin 2.0, the Compose Compiler and runtime are required in the classpath https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-compiler.html
85+
testImplementation(libs.androidx.activity.compose)
86+
testImplementation(platform(libs.androidx.compose.bom))
9087
androidTestImplementation(libs.androidx.junit)
9188
androidTestImplementation(libs.androidx.espresso.core)
9289
androidTestImplementation(platform(libs.androidx.compose.bom))
9390
androidTestImplementation(libs.androidx.ui.test.junit4)
94-
debugImplementation(libs.androidx.ui.tooling)
95-
debugImplementation(libs.androidx.ui.test.manifest)
91+
androidTestImplementation(libs.androidx.ui.tooling)
92+
androidTestImplementation(libs.androidx.ui.test.manifest)
9693

9794
testImplementation(libs.mockk)
9895
testImplementation(libs.mockk.android)

0 commit comments

Comments
 (0)