Skip to content

Commit 4552b79

Browse files
authored
Merge pull request #81 from TelemetryDeck/feat/set-namespace-via-builder
Allow setting namespace via the builder
2 parents 43e974f + 7cecd49 commit 4552b79

File tree

5 files changed

+24
-5
lines changed

5 files changed

+24
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ The Kotlin SDK for TelemetryDeck is available from Maven Central at the followin
3333
```groovy
3434
// `build.gradle`
3535
dependencies {
36-
implementation 'com.telemetrydeck:kotlin-sdk:6.0.0'
36+
implementation 'com.telemetrydeck:kotlin-sdk:6.0.1'
3737
}
3838
```
3939

4040
```kotlin
4141
// `build.gradle.kts`
4242
dependencies {
43-
implementation("com.telemetrydeck:kotlin-sdk:6.0.0")
43+
implementation("com.telemetrydeck:kotlin-sdk:6.0.1")
4444
}
4545
```
4646

lib/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ dependencies {
107107
}
108108

109109
mavenPublishing {
110-
coordinates("com.telemetrydeck", "kotlin-sdk", "6.0.0")
110+
coordinates("com.telemetrydeck", "kotlin-sdk", "6.0.1")
111111

112112
pom {
113113
name = "TelemetryDeck SDK"

lib/src/main/java/com/telemetrydeck/sdk/TelemetryDeck.kt

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,8 @@ class TelemetryDeck(
462462
private var identityProvider: TelemetryDeckIdentityProvider? = null,
463463
private var sessionProvider: TelemetryDeckSessionManagerProvider? = null,
464464
private var telemetryClientFactory: TelemetryApiClientFactory? = null,
465-
private var signalCache: SignalCache? = null
465+
private var signalCache: SignalCache? = null,
466+
private var namespace: String? = null,
466467
) {
467468
/**
468469
* Set the [TelemetryDeck] configuration.
@@ -552,6 +553,10 @@ class TelemetryDeck(
552553
this.logger = debugLogger
553554
}
554555

556+
fun namespace(namespace: String?) = apply {
557+
this.namespace = namespace
558+
}
559+
555560
fun build(context: Context?): TelemetryDeck {
556561
var config = this.configuration
557562
val appID = this.appID
@@ -602,6 +607,10 @@ class TelemetryDeck(
602607
if (showDebugLogs != null) {
603608
config.showDebugLogs = showDebugLogs
604609
}
610+
val namespace = this.namespace
611+
if (!namespace.isNullOrBlank()) {
612+
config.namespace = namespace
613+
}
605614

606615
val logger: DebugLogger = this.logger ?: TelemetryManagerDebugLogger
607616
logger.configure(config.showDebugLogs)

lib/src/main/java/com/telemetrydeck/sdk/providers/EnvironmentParameterProvider.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class EnvironmentParameterProvider : TelemetryDeckProvider {
2929
private val platform: String = "Android"
3030
private val os: String = "Android"
3131
private val sdkName: String = "KotlinSDK"
32-
private val sdkVersion: String = "6.0.0"
32+
private val sdkVersion: String = "6.0.1"
3333

3434
override fun register(ctx: Context?, client: TelemetryDeckSignalProcessor) {
3535
appendContextSpecificParams(ctx, client.debugLogger)

lib/src/test/java/com/telemetrydeck/sdk/TelemetryDeckTests.kt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,16 @@ class TelemetryDeckTests {
122122
Assert.assertEquals("salty", result.configuration.salt)
123123
}
124124

125+
@Test
126+
fun telemetryDeck_builder_set_namespace() {
127+
val sut = TelemetryDeck.Builder()
128+
val result =
129+
sut.appID("32CB6574-6732-4238-879F-582FEBEB6536")
130+
.namespace("acme")
131+
.build(null)
132+
Assert.assertEquals("acme", result.configuration.namespace)
133+
}
134+
125135
@Test
126136
fun telemetryDeck_builder_set_showDebugLogs() {
127137
val sut = TelemetryDeck.Builder()

0 commit comments

Comments
 (0)