feat(refactor): direct build props

Author: Phil-NHS

.github/workflows/reuseable-ci-checks.yml

@@ -34,7 +34,7 @@ env:
   #TELBLAZOR_PACKAGE_SOURCE: "https://nuget.pkg.github.com/TechnologyEnhancedLearning/index.json"
 
   # Build Set Up
-  # qqqq making below true for now to match local
+  # May need coverlet.collector xplat if using the packaged version to test
   USE_TEL_BLAZOR_COMPONENTS_PROJECT_REFERENCE: true
   DISABLE_PACKAGE_GENERATION: true
   E2E_TRACING_ENABLED: false
@@ -123,7 +123,6 @@ jobs:
               /p:TELBlazorPackageSource=$TELBLAZOR_PACKAGE_SOURCE \
               /p:DisablePackageGeneration=$DISABLE_PACKAGE_GENERATION \
               /p:E2ETracingEnabled=$E2E_TRACING_ENABLED
-              
 
     reuseable-ci-checks-branch-name-check:
       name: Check branch names
@@ -202,12 +201,10 @@ jobs:
               # paths["./TELBlazor.Components.ShowCase.E2ETests.WasmServerHost/TELBlazor.Components.ShowCase.E2ETests.WasmServerHost.Client/wwwroot/appsettings.Production.json"]='${{ secrets.WASMSERVERHOSTCLIENT_APPSETTINGS_PRODUCTION }}'
               # paths["./TELBlazor.Components.ShowCase.E2ETests.WasmServerHost/TELBlazor.Components.ShowCase.E2ETests.WasmServerHost/appsettings.Production.json"]='${{ secrets.WASMSERVERHOST_APPSETTINGS_PRODUCTION }}'
 
-  
               for path in "${!paths[@]}"; do
                 mkdir -p "$(dirname "$path")"
                 printf '%s' "${paths[$path]}" > "$path"
               done
-    
       
           - name: Set up Node.js so we have gulp for retrieving TEL Frontend Css
             uses: actions/setup-node@v4
@@ -235,20 +232,6 @@ jobs:
                 /p:DisablePackageGeneration=$DISABLE_PACKAGE_GENERATION \
                 /p:E2ETracingEnabled=$E2E_TRACING_ENABLED \
                 /p:HeadlessTesting=$HEADLESS_TESTING 
-                
-                # /p:CollectCoverage=true \
-                # /p:CoverletOutputFormat=cobertura \
-                # /p:Threshold=50 \
-                # /p:ThresholdType=line \
-                # /p:ThresholdStat=total \
-                # /p:ThresholdBranch=50 \
-                # /p:ThresholdMethod=50 \
-                # /p:Include="[TELBlazor.Components]*" \
-                # /p:ExcludeByAttribute=ExcludeFromCodeCoverage \
-                # /p:IncludeTestAssembly=true \
-                # /p:CoverletOutput=/home/runner/work/TELBlazor/TELBlazor/AllTestResults/ \
-                # /p:MergeWith=/home/runner/work/TELBlazor/TELBlazor/AllTestResults/coverage.json
-             #               /p:ExcludeByFile="**/Program.cs,**/Components/TestComponents/*.*" \
               
           - name: Build solution without generating new package
             env:
@@ -264,30 +247,9 @@ jobs:
                 /p:E2ETracingEnabled=$E2E_TRACING_ENABLED \
                 /p:HeadlessTesting=$HEADLESS_TESTING 
                 
-                # /p:CollectCoverage=true \
-                # /p:CoverletOutputFormat=cobertura \
-                # /p:Threshold=50 \
-                # /p:ThresholdType=line \
-                # /p:ThresholdStat=total \
-                # /p:ThresholdBranch=50 \
-                # /p:ThresholdMethod=50 \
-                # /p:Include="[TELBlazor.Components]*" \
-                # /p:ExcludeByAttribute=ExcludeFromCodeCoverage \
-                # /p:IncludeTestAssembly=true \
-                # /p:CoverletOutput=/home/runner/work/TELBlazor/TELBlazor/AllTestResults/ \
-                # /p:MergeWith=/home/runner/work/TELBlazor/TELBlazor/AllTestResults/coverage.json
-                
-             #               /p:ExcludeByFile="**/Program.cs,**/Components/TestComponents/*.*" \
               
           - name: Ensure browsers are installed
             run: pwsh TELBlazor.Components.ShowCase.E2ETests/bin/Debug/net8.0/playwright.ps1 install --with-deps  
-          
-          - name: Debug DLL/PDB outputs
-            run: |
-              find . -name "TELBlazor.Components.UnitTests.dll"
-              find . -name "TELBlazor.Components.UnitTests.pdb"
-
-
 
 
           - name: Run tests with coverage threshold check
@@ -310,22 +272,8 @@ jobs:
                 /p:E2ETracingEnabled=$E2E_TRACING_ENABLED \
                 /p:HeadlessTesting=$HEADLESS_TESTING 
                 
-                # /p:CollectCoverage=true \
-                # /p:CoverletOutputFormat=cobertura \
-                # /p:Threshold=50 \
-                # /p:ThresholdType=line \
-                # /p:ThresholdStat=total \
-                # /p:ThresholdBranch=50 \
-                # /p:ThresholdMethod=50 \
-                # /p:Include="[TELBlazor.Components]*" \
-                # /p:ExcludeByAttribute=ExcludeFromCodeCoverage \
-                # /p:IncludeTestAssembly=true \
-                # /p:CoverletOutput=/home/runner/work/TELBlazor/TELBlazor/AllTestResults/ \
-                # /p:MergeWith=/home/runner/work/TELBlazor/TELBlazor/AllTestResults/coverage.json
             continue-on-error: true
 
-#               /p:ExcludeByFile="**/Program.cs,**/Components/TestComponents/*.*" \
-
           - name: Generate Coverage Report
             run: |
               dotnet reportgenerator \
@@ -340,11 +288,7 @@ jobs:
             with:
               name: coverage-report
               path: CoverageReport
-           
-          # - name: Debug PACKAGES_TOKEN value (Optional) qqqq
-            # run: |
-              # echo "PACKAGES_TOKEN is set."
-              # echo "PACKAGES_TOKEN=$PACKAGES_TOKEN"  # This should print nothing, it's a secret!
+          
 
           - name: Get artifact location
             env:
@@ -362,13 +306,6 @@ jobs:
               echo "Artifact URL: $ARTIFACT_URL"
               echo "artifact_url=$ARTIFACT_URL" >> $GITHUB_ENV
               
-              
-      # # Extract the download URL from the artifact list (first artifact in the list)
-      # #ARTIFACT_URL=$(echo "$ARTIFACT_LIST" | jq -r '.artifacts[0].archive_download_url')
-      # ARTIFACT_URL=$(echo "$ARTIFACT_LIST" | jq -r '.artifacts[0].url')
-      # # Echo the artifact URL to confirm
-      # echo "Artifact URL: $ARTIFACT_URL"
-      # echo "artifact_url=$ARTIFACT_URL" >> $GITHUB_ENV
           
           - name: Trigger workflow in TELBlazor-CodeReport repo
             env:
@@ -396,12 +333,6 @@ jobs:
               fi
             
 
-          # - name: Fail if code coverage report didnt meet threshold qqqq todo better to parse the report than rerun tests
-            # run: dotnet test
-                        
-
-         # - reuseable-ci-checks-unit-tests
-        # - reuseable-ci-checks-e2e-tests
     reuseable-ci-checks-check-for-failed-jobs:
       name: Check for failures
       if: ${{ inputs.runall }}
@@ -411,8 +342,6 @@ jobs:
         - reuseable-ci-checks-commitlint
         - reuseable-ci-e2e-unit-tests
 
-                  # echo "Unit Tests: ${{ needs.reuseable-ci-checks-unit-tests.outputs.status }}"
-            # echo "E2E Tests: ${{ needs.reuseable-ci-checks-e2e-tests.outputs.status }}"
       runs-on: ubuntu-latest
       steps:
         - name: Check Job Results
@@ -421,9 +350,6 @@ jobs:
             echo "Branch Name Check: ${{ needs.reuseable-ci-checks-branch-name-check.outputs.status }}"
             echo "Commit Lint Check: ${{ needs.reuseable-ci-checks-commitlint.outputs.status }}"
             echo "Tests: ${{ needs.reuseable-ci-e2e-unit-tests.outputs.status }}"
-
-                  # "${{ needs.reuseable-ci-checks-unit-tests.outputs.status }}" != "success" || \
-                  # "${{ needs.reuseable-ci-checks-e2e-tests.outputs.status }}" != "success" || \
                   
             # Check if any job is not success (failure, cancelled, skipped)
             if [[ "${{ needs.reuseable-ci-checks-solution-build.outputs.status }}" != "success" || \

.gitignore

@@ -190,3 +190,4 @@ CHANGELOG.md
 /TELBlazor.Components.UnitTests/coverage.json
 /TELBlazor.Components.UnitTests/coverage.cobertura.xml
 /CoverageReport
+/TELBlazor.Components/wwwroot/css/nhsuk.css