Skip to content

Commit 7b41277

Browse files
authored
Merge pull request #66 from TechnologyEnhancedLearning/feat-button-for-cicd-testing
Feat button for cicd testing
2 parents 6bc0050 + a530dad commit 7b41277

File tree

11 files changed

+39
-19
lines changed

11 files changed

+39
-19
lines changed

CHANGELOG.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
1-
# [1.6.0](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.5.0...v1.6.0) (2025-06-06)
1+
# [1.7.0-feat-button-for-cicd-testing.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.6.0...v1.7.0-feat-button-for-cicd-testing.1) (2025-06-09)
22

33

44
### Features
55

6-
* **button:** nav ([075d01f](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/075d01f3aa5a60afd55ac96f6fd1d257a344c302))
7-
8-
# [1.6.0-feat-button-for-cicd-testing.1](https://github.com/TechnologyEnhancedLearning/TELBlazor/compare/v1.5.0...v1.6.0-feat-button-for-cicd-testing.1) (2025-06-06)
9-
10-
11-
### Features
12-
13-
* **button:** nav ([075d01f](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/075d01f3aa5a60afd55ac96f6fd1d257a344c302))
6+
* **button:** lower testing threshold ([63ded2c](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/63ded2c82e656cdb94b9f98a6d38eeda9c7bc0ba))
7+
* **button:** optional implementation ([9a12d3c](https://github.com/TechnologyEnhancedLearning/TELBlazor/commit/9a12d3ce6ec6196c536958ab554f20a307c8096f))

Directory.Build.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
<!-- coverlet.msbuild, specifically msbuild props here we set when cicd testing fails on coverage -->
88
<CollectCoverage>true</CollectCoverage>
99
<CoverletOutputFormat>cobertura</CoverletOutputFormat>
10-
<Threshold>50</Threshold>
10+
<Threshold>30</Threshold>
1111
<ThresholdType>line</ThresholdType>
1212
<ThresholdStat>total</ThresholdStat>
13-
<ThresholdBranch>50</ThresholdBranch>
14-
<ThresholdMethod>50</ThresholdMethod>
13+
<ThresholdBranch>30</ThresholdBranch>
14+
<ThresholdMethod>30</ThresholdMethod>
1515

1616
<!-- What to test -->
1717
<Include>[TELBlazor.Components]*</Include>

TELBlazor.Components.ShowCase.E2ETests.WasmServerHost/TELBlazor.Components.ShowCase.E2ETests.WasmServerHost/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
{
6868
return new TELBlazorBaseComponentConfiguration
6969
{
70-
JSEnabled = true, //if we are inject the client then it is true
70+
JSEnabled = true, //See mvcblazor logic for proper implementation
7171
HostType = $"{builder.Configuration["Properties:Environment"]} {builder.Configuration["Properties:Application"]}"
7272
};
7373
});

TELBlazor.Components.ShowCase.E2ETests/Helpers/BrowserHelper.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace TELBlazor.Components.ShowCase.E2ETests.Helpers
99
{
1010
public static class BrowserHelper
1111
{
12-
// Setting value using PackageSetting.props potentially replace appsettings.Test.json in future especially if apis
12+
// qqqq Setting value using PackageSetting.props potentially replace appsettings.Test.json in future especially if using apis during testing
1313
static bool headless =>
1414
#if HEADLESS_TESTING
1515
true;
@@ -22,7 +22,6 @@ public static async Task<IBrowserContext> CreateBrowserContextAsync(IPlaywright
2222

2323
IBrowser browser;
2424

25-
bool headless = (bool.TryParse(Environment.GetEnvironmentVariable("HEADLESS_TESTING"), out var result) && result);
2625
switch (browserType.ToLower())
2726
{
2827
case "chromium":
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gitinclude

TELBlazor.Components.ShowCase.Shared/TELBlazor.Components.ShowCase.Shared.csproj

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717
<ItemGroup>
1818
<Content Remove="packages.lock.json" />
1919
</ItemGroup>
20+
<ItemGroup>
21+
<None Remove="Services\HelperServices\gitinclude.txt" />
22+
</ItemGroup>
23+
<ItemGroup>
24+
<Content Include="Services\HelperServices\gitinclude.txt" />
25+
</ItemGroup>
2026
<ItemGroup>
2127
<ProjectReference Include="..\TELBlazor.Components\TELBlazor.Components.csproj" Condition="'$(UseTELBlazorComponentsProjectReference)' == 'true'" />
2228
</ItemGroup>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gitinclude

TELBlazor.Components/Core/DI/DI.cs renamed to TELBlazor.Components/OptionalImplementations/Core/DI/DI.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
using System.Threading.Tasks;
1111
using TELBlazor.Components.Core.Configuration;
1212

13-
namespace TELBlazor.Components.Core.DI
13+
namespace TELBlazor.Components.OptionalImplementations.Core.DI
1414
{
1515
public static class DI
1616
{

TELBlazor.Components/TELBlazor.Components.csproj

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@
3434
<ItemGroup>
3535
<PackageReference Include="Microsoft.AspNetCore.Components.Web" />
3636
<PackageReference Include="Microsoft.Extensions.Http" />
37+
<!--OptionalImplementations add package weight in future it may be beneficial to make them a seperate package-->
38+
<PackageReference Include="Blazored.LocalStorage" />
39+
<PackageReference Include="Serilog" />
3740
</ItemGroup>
3841
<ItemGroup>
3942
<Content Remove="packages.lock.json" />
@@ -45,6 +48,9 @@
4548
<Content Remove="..\CICDPackageLocation\**\*" />
4649
<None Remove="..\CICDPackageLocation\**\*" />
4750
</ItemGroup>
51+
<ItemGroup>
52+
<Content Include="Core\DI\gitinclude.txt" />
53+
</ItemGroup>
4854
<ItemGroup>
4955
<Folder Include="Assets\" />
5056
<Folder Include="wwwroot\css\" />
@@ -68,9 +74,7 @@
6874
2) Tell gulp to run the gulpfile in this project directory
6975
3) Gulp to add the TELFrontend css version to version info file
7076
-->
71-
<Exec
72-
WorkingDirectory="$(MSBuildProjectDirectory)/.."
73-
Command="npx gulp --cwd &quot;$(MSBuildProjectDirectory)&quot; --gulpfile &quot;$(MSBuildProjectDirectory)/gulpfile.js&quot;" />
77+
<Exec WorkingDirectory="$(MSBuildProjectDirectory)/.." Command="npx gulp --cwd &quot;$(MSBuildProjectDirectory)&quot; --gulpfile &quot;$(MSBuildProjectDirectory)/gulpfile.js&quot;" />
7478
</Target>
7579

7680
</Project>

0 commit comments

Comments
 (0)