Skip to content

Commit 77dbf5d

Browse files
committed
feat(cicd): Tidy and version increment check
1 parent bb4f26b commit 77dbf5d

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

TELBlazor.Components/OptionalImplementations/Test/TestComponents/SearchExperiment/SearchExperimentServiceOpenApi.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace TELBlazor.Components.OptionalImplementations.Test.TestComponents.Searc
1414
{
1515
public class SearchExperimentServiceOpenApi :ISearchExperimentService
1616
{
17-
//qqqq can do alot better
17+
//qqqq very very much just bit of proof of concept.
1818
private readonly HttpClient _httpClient;
1919
private readonly string _baseUrl;
2020
private readonly ILogger<SearchExperimentServiceOpenApi> _logger; // logger

TELBlazor.Components/TELBlazor.Components.csproj

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,12 @@
5959
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
6060
</Content>
6161
</ItemGroup>
62-
<!--qqqq tidy up and comment later-->
63-
<!--Ensure no stale version cs files and that new ones are generated-->
64-
<!--<Delete Files="TELBlazorPackageVersion/VersionInfo.TELBlazor.cs" />
65-
<Delete Files="TELBlazorPackageVersion/VersionInfo.cs" />-->
6662

63+
<!--
64+
Build partial classes for the version info. Compile version into before rest of the project so accessible for razor.
65+
-->
6766
<PropertyGroup>
68-
<!-- Exclude generated files from auto-inclusion to prevent duplicates -->
67+
<!-- Exclude generated files from auto-inclusion to prevent duplicates as we want to control order of compilation-->
6968
<DefaultItemExcludes>$(DefaultItemExcludes);TELBlazorPackageVersion\VersionInfo.*.cs</DefaultItemExcludes>
7069
</PropertyGroup>
7170
<Target Name="PreBuildCleanup" BeforeTargets="GenerateTELBlazorPackageVersion;RunGulp;CoreCompile;BeforeCompile">
@@ -85,14 +84,10 @@ namespace TELBlazor.Components.TELBlazorPackageVersion
8584
Overwrite="true"
8685
Encoding="UTF-8" />
8786
</Target>
88-
<!-- qqqq was this beforetargets corecompile -->
8987
<Target Name="RunGulp" DependsOnTargets="GenerateTELBlazorPackageVersion" BeforeTargets="CoreCompile;BeforeCompile">
9088
<Exec WorkingDirectory="$(MSBuildProjectDirectory)/.."
9189
Command="npx gulp --cwd &quot;$(MSBuildProjectDirectory)&quot; --gulpfile &quot;$(MSBuildProjectDirectory)/gulpfile.js&quot;" />
9290
</Target>
93-
94-
95-
<!--qqqq i dont think this should be needed-->
9691
<Target Name="CompileVersionInfoBeforeRazor" DependsOnTargets="GenerateTELBlazorPackageVersion;RunGulp;PreBuildCleanup" BeforeTargets="CoreCompile;BeforeCompile">
9792
<ItemGroup>
9893
<Compile Include="TELBlazorPackageVersion\VersionInfo.TELBlazor.cs" />

0 commit comments

Comments
 (0)