Skip to content

Commit ae4bbad

Browse files
committed
fix(pr check): check
1 parent e040b42 commit ae4bbad

File tree

1 file changed

+22
-7
lines changed

1 file changed

+22
-7
lines changed

.github/workflows/pull_request.yml

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,8 @@
11
name: Pull Request Checks
22

3-
on:
4-
pull_request:
5-
branches:
6-
- '**'
7-
3+
on: pull_request
84
jobs:
95

10-
11-
126
branch-name-check:
137
name: Enforce Branch Name Convention
148
runs-on: ubuntu-latest
@@ -31,6 +25,7 @@ jobs:
3125
#continue-on-error: true
3226

3327
commitlint:
28+
name: commitlint
3429
# qqqq repo will need branch protection rules and PR Template
3530
runs-on: ubuntu-latest
3631
if: success() || failure()
@@ -45,6 +40,7 @@ jobs:
4540

4641

4742
gitguardian-scan:
43+
name: gitguardian
4844
runs-on: ubuntu-latest
4945
if: success() || failure()
5046
steps:
@@ -57,6 +53,7 @@ jobs:
5753
#continue-on-error: true # we dont want secrets going further and the keys need to be changed if this is triggered
5854

5955
Unit-Tests:
56+
name: todo unit tests
6057
runs-on: ubuntu-latest
6158
if: success() || failure()
6259
steps:
@@ -66,6 +63,7 @@ jobs:
6663

6764

6865
E2E-Tests:
66+
name: todo e2e tests
6967
runs-on: ubuntu-latest
7068
if: success() || failure()
7169
steps:
@@ -74,12 +72,29 @@ jobs:
7472
#continue-on-error: true
7573

7674
Code-Coverage:
75+
name: code coverage
7776
runs-on: ubuntu-latest
7877
steps:
7978
- name: Code Coverage
8079
run: echo "TODO Code Coverage"
8180
#continue-on-error: true
8281

82+
All-Checks-Passed:
83+
name: all checks passed
84+
runs-on: ubuntu-latest
85+
needs:
86+
- branch-name-check
87+
- commitlint
88+
- gitguardian-scan
89+
- Unit-Tests
90+
- E2E-Tests
91+
- Code-Coverage
92+
if: ${{ success() }}
93+
steps:
94+
- name: all checks passed steps
95+
run: echo "allow all checks to run incase multiple fails then fail here"
96+
97+
8398

8499

85100

0 commit comments

Comments
 (0)