Skip to content

Commit 9800d0d

Browse files
committed
fix(just qqqqs tidy up): a chore really
1 parent 15fb86c commit 9800d0d

File tree

3 files changed

+36
-3
lines changed

3 files changed

+36
-3
lines changed

.github/workflows/pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
BRANCH_NAME="${GITHUB_HEAD_REF:-${GITHUB_REF_NAME}}"
1616
echo "Validating branch name: $BRANCH_NAME"
1717
18-
if [[ "$BRANCH_NAME" =~ ^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|sample|security|config|bugfix|hotfix)-[a-zA-Z0-9._/-]+$ ]] || [[ "$BRANCH_NAME" == "master" ]]; then
18+
if [[ "$BRANCH_NAME" =~ ^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|sample|security|config|bugfix|hotfix)-[a-zA-Z0-9._/-]+$ ]] || [[ "$BRANCH_NAME" == "master" ]] || [[ "$BRANCH_NAME" == "Automatic_version_update_dependabot" ]]; then
1919
echo "✅ Branch name is valid"
2020
else
2121
echo "❌ Invalid branch name: $BRANCH_NAME"

ReadMe.md

Lines changed: 35 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Good to know
22

3-
A purpose is quick cicd.
3+
The purpose is quick cicd.
44
You can change your version of your package in the centralised solution and it will be picked up in consuming projects.
55
You can optionally use a project reference for faster development by setting a flag.
66
A build number could be automated into package names, the package already is automatically created on build.
@@ -99,21 +99,55 @@ builds projects not a whole solution build.
9999
#### Pull request
100100
- just some checks they can be run even if they fail to see if there are multiple errors. They only show temporarily in the pr ui section of the
101101
git pull request but can be seen in actions.
102+
They have been added in the branch rules which runs jobs selected from existing pipelines. This should add them to the list of checks.
102103

103104

104105
#### Release
105106
- similar to dev but without tests as these have already happened and no feature name in package, and the gh-page is released on this repo.
106107

108+
## local development
109+
- use project reference
110+
- or
111+
- in local packages increase bcl version
112+
- build the package
113+
- run TestHostPrerenderWASM (not client)
107114

108115
## Notes
109116
Also DevServer needed adding to .client
117+
NPM is not centralised like nuget because only using for just the TEL package css
118+
119+
### Branch naming and commit naming see realserc
120+
121+
feat: A new feature
122+
fix: A bug fix
123+
docs: Documentation only changes
124+
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
125+
refactor: A code change that neither fixes a bug nor adds a feature
126+
perf: A code change that improves performance
127+
test: Adding missing or correcting existing tests
128+
chore: Changes to the build process or auxiliary tools and libraries such as documentation generation
129+
130+
### Refs
131+
[How to make 404 redirect for spa behaviour](https://blog.elmah.io/blazor-wasm-404-error-and-fix-for-github-pages/)
132+
[git nektos act](https://github.com/nektos/act)
133+
[nektos](https://nektosact.com/)
134+
- [Confluence gitguardian](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3855253505/GitGuardian+Setup+-+Simplified+Version)
135+
- [Confluence gitguardian extra](https://hee-tis.atlassian.net/wiki/spaces/TP/pages/3849289743/Secrete+Detection+-+GitGuardian+Setup+Extensive+Version)
136+
137+
138+
# Outstanding
139+
- git checks off branch rules and pull request yml seem not to be triggering
140+
- auto merge pr doesnt seem to trigger atm
141+
- some of the local variable set bools like for using project references are disabled
110142

111143
# Future Recommendation
112144

113145
There are options for making packing the blazor more efficient, as in smaller for the browser using it.
114146
The would be worth exploring there are recommendations in the build tasks when the pipeline runs, also mudblazor is open and any process they have is
115147
worth considering.
116148

149+
Use hooks for gitguardian and commitlint
150+
117151
# Where to see the site
118152

119153

SharedPages/wwwroot/css/app.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ code {
7777
}
7878
.shared-pages-red-text {
7979
color: red;
80-
/*qqqq test*/
8180
}
8281
/* RCL Styles remember bundled scoped css we may not use it but it is extremely normal to so we may in future*/
8382
@import '_content/Package.BlazorComponentLibrary/Package.BlazorComponentLibrary.bundle.scp.css';

0 commit comments

Comments
 (0)