Skip to content

Commit 47a10bb

Browse files
committed
feat(test breaking): heres a change
BREAKING CHANGE: 10
1 parent 2d6de4d commit 47a10bb

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

.github/workflows/dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ jobs:
421421
422422
- name: Publish client using client release .csproj logic
423423
env:
424-
INDEPENDANT_CLIENT_GH_PAGES: true
424+
INDEPENDENT_CLIENT_GH_PAGES: true
425425
run: |
426426
dotnet publish ./TestHostPrerenderWASM/TestHostPrerenderWASM.Client/TestHostPrerenderWASM.Client.csproj --configuration Release \
427427
/p:BCLVersion=$BCL_VERSION \

TestHostPrerenderWASM/TestHostPrerenderWASM.Client/Program.cs

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,29 +5,16 @@
55

66
var builder = WebAssemblyHostBuilder.CreateDefault(args);
77

8-
//Be careful we have two entry points to enable the client to be both a standalone app and the client for the server app.
9-
// removing the below, app.razor, and index.html would put the project back to being just for the testing host (WebAssembly.DevServer could be removed from nuget too)
10-
if (builder.HostEnvironment.IsProduction()) //qqqq worked but want release mode not to be tied to this
11-
{
12-
builder.RootComponents.Add<App>("#app");
13-
builder.RootComponents.Add<HeadOutlet>("head::after");
14-
builder.Services.AddScoped(sp => new HttpClient { BaseAddress = new Uri(builder.HostEnvironment.BaseAddress) });
158

16-
}
179

18-
if (Environment.GetEnvironmentVariable("INDEPENDANT_CLIENT_GH_PAGES") != null)
10+
if (Environment.GetEnvironmentVariable("INDEPENDENT_CLIENT_GH_PAGES") != null)
1911
{
2012
builder.RootComponents.Add<App>("#app");
2113
builder.RootComponents.Add<HeadOutlet>("head::after");
2214
builder.Services.AddScoped(sp => new HttpClient { BaseAddress = new Uri(builder.HostEnvironment.BaseAddress) });
2315
}
2416

25-
//#if GH_PAGE_RELEASE //put something like this back in
26-
//builder.RootComponents.Add<App>("#app");
27-
//builder.RootComponents.Add<HeadOutlet>("head::after");
28-
//builder.Services.AddScoped(sp => new HttpClient { BaseAddress = new Uri(builder.HostEnvironment.BaseAddress) });
29-
//#endif
30-
//qqqqqq this is where it will be failing
17+
3118
await builder.Build().RunAsync();
3219

3320

0 commit comments

Comments
 (0)