Skip to content

Commit 63053a5

Browse files
author
PdeBot
committed
Fixed bug that would cause the plugin not to auto update from 1.16 to 1.16.1.
1 parent 4380361 commit 63053a5

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

src/main/java/com/gmail/val59000mc/Updater.java

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,18 +244,32 @@ public String toString(){
244244
return version;
245245
}
246246

247+
private int getVersionNumber(int index){
248+
if (versionNums.length > index){
249+
return versionNums[index];
250+
}
251+
252+
// This version doesn't have that many version numbers, so return 0 by default.
253+
return 0;
254+
}
255+
247256
private boolean isNewerThan(Version version){
248257
if (equals(version)){
249258
return false;
250259
}
251260

252-
for (int i = 0; i < versionNums.length; i++){
261+
int numCount = versionNums.length;
262+
if (version.versionNums.length > numCount){
263+
numCount = version.versionNums.length;
264+
}
265+
266+
for (int i = 0; i < numCount; i++){
253267
// This version is smaller than arg version so this is old
254-
if (versionNums[i] < version.versionNums[i]){
268+
if (getVersionNumber(i) < version.getVersionNumber(i)){
255269
return false;
256270
}
257271
// This version is bigger than arg version so this is new
258-
if (versionNums[i] > version.versionNums[i]){
272+
if (getVersionNumber(i) > version.getVersionNumber(i)){
259273
return true;
260274
}
261275

0 commit comments

Comments
 (0)