Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slim hhvm fortunes, some cleanup, and a little enhancement #2309

Conversation

herloct
Copy link
Contributor

@herloct herloct commented Oct 19, 2016

  • Fix Missing Tests #2178: Add charset=utf8 to PDO DSN, so HHVM could show japanese characters.
  • Cleanup: Add some whitespace for better readability.
  • Enchancement: Move UPDATE prepared statement outside of loop.

cc @knewmanTE

@herloct herloct changed the title Fix slim hhvm fortunes, some cleanup, and a little enhancement Fix #2178 slim hhvm fortunes, some cleanup, and a little enhancement Oct 19, 2016
@herloct herloct changed the title Fix #2178 slim hhvm fortunes, some cleanup, and a little enhancement Fix slim hhvm fortunes, some cleanup, and a little enhancement Oct 19, 2016
@ashawnbandy-te-tfb
Copy link
Contributor

Just wanted to apologize for the delay in reviewing this and merging it in; we're in the thick of preparing everything for our Round 13 release. As soon as Round 13 is over, we'll get to the Round 14 pull requests!

@herloct
Copy link
Contributor Author

herloct commented Oct 28, 2016

@ashawnbandy-te-tfb Thanks
But i'm not really sure if my PR were right.
Since TFB installation on my vagrant seems failed, it always asking for password (database, etc) when running the test.
So this PR only tested by using travis-ci, but it pass.

@knewmanTE
Copy link
Contributor

@herloct Thanks for the pull request! I ran the slim, slim-hhvm, and slim-php5 tests locally and they all passed, so I'll merge this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants