Fintrospect: Upgrade to lib version, and tweak JVM parameters #2264
Conversation
Changes to Fintrospect version and performance tweaks
…easurement. also performance tweaks to setup script
|
This is to be added to Round 13 preview please |
| .withMonitor(NullMonitor) | ||
| .withTracer(NullTracer) | ||
| .withMaxConcurrentPrepareStatements(256) | ||
| .newRichClient("localhost:3306") |
There was a problem hiding this comment.
Could you add a line to your setup.sh file that replaces localhost here with the system variable $DBHOST? Here's an example of another framework doing something similar. We ask that you do this because localhost will work for Travis and for local testing, but on our production runs, we have different IP addresses for the App, Database, and Client servers.
There was a problem hiding this comment.
Also, your /fortunes test appears to be failing even on Travis and on a single local machine, so perhaps there's something that is misconfigured here?
|
@knewmanTE Sorry - my bad. The DB tests aren't ready to be plugged in yet (meant for R14), so I've removed them from the config. If you could merge the rest then that'd be awesome. :) |
No description provided.