Update Finagle to 6.36 #2233
Merged
Update Finagle to 6.36 #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val dateFormat: DateFormat = new SimpleDateFormat("E, dd MMM yyyy HH:mm:ss z") | ||
|
|
||
| val dateFormat: ThreadLocal[DateFormat] = new ThreadLocal[DateFormat] { | ||
| override def initialValue: DateFormat = new SimpleDateFormat("E, dd MMM yyyy HH:mm:ss z") |
Contributor
There was a problem hiding this comment.
The format here should be "E, dd MMM yyyy HH:mm:ss 'GMT'". See the issue we hit and the pull-request here: twitter/finatra#312
Contributor
Author
There was a problem hiding this comment.
Thanks @cacoco! I updated the PR to use request API req.date = ??? instead that uses the right date format.
vkostyukov
force-pushed
the
vk/update-finagle
branch
from
436adb6 to
ddbdc20
Compare
Contributor
|
@vkostyukov looks good! we'll do our best to get this into round 13! |
Contributor
Author
|
Thank you, @knewmanTE! |
ashawnbandy-te-tfb
pushed a commit
to ashawnbandy-te-tfb/FrameworkBenchmarks
that referenced
this pull request
Sep 9, 2016
This was referenced Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Finagle to 6.36 and also makes some misc changes:
DateTimeFormata thread-local since it's not thread-safe and it's not fair to share itPlease let me know if there anything I can do/change to make this PR make it to the Round 13.